From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index Date: Mon, 23 Feb 2015 15:57:40 +0000 Message-ID: <54EB4DF4.1040204@linaro.org> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-15-git-send-email-julien.grall@linaro.org> <1424451314.30924.358.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YPvOb-0007Pq-Ct for xen-devel@lists.xenproject.org; Mon, 23 Feb 2015 15:58:09 +0000 Received: by mail-wi0-f182.google.com with SMTP id l15so18347681wiw.3 for ; Mon, 23 Feb 2015 07:58:07 -0800 (PST) In-Reply-To: <1424451314.30924.358.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 20/02/15 16:55, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote: >> There is no reason to use signed integer for an index. > > Did you check for now pointless "if ( uthing < 0 ) which a picky > compiler might whinge about? I just checked and we don't have a such test in those function. BTW, I think clang is picky on pointless if ( ufoo < 0 ) but we don't support it on ARM right now. >> Signed-off-by: Julien Grall >> Acked-by: Stefano Stabellini > > Acked-by: Ian Campbell Thanks, -- Julien Grall