From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest Date: Mon, 23 Feb 2015 16:01:11 +0000 Message-ID: <54EB4EC7.4050502@linaro.org> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-16-git-send-email-julien.grall@linaro.org> <1424705450.27930.164.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YPvS0-000894-47 for xen-devel@lists.xenproject.org; Mon, 23 Feb 2015 16:01:40 +0000 Received: by mail-wi0-f182.google.com with SMTP id l15so18386966wiw.3 for ; Mon, 23 Feb 2015 08:01:38 -0800 (PST) In-Reply-To: <1424705450.27930.164.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 23/02/15 15:30, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote: > >> +/* This limit is used by the hypercalls to restrict the size of the path */ >> +#define DEVICE_TREE_MAX_PATHLEN 1024 > > Is this something you've made up or derived from the DT spec/ePAPR etc? I didn't find a such requirements on the spec. I chose this number based on the linux pathlen because the path is also used in the sysfs (/sys/firmware/devicetree). > Apart from this the patch seems fine, clarifying the genesis of that > number in the commit log would be sufficient for me. I will update the commit message. Regards, -- Julien Grall