From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 16/24] xen/passthrough: Introduce
	iommu_construct
Date: Mon, 23 Feb 2015 16:04:55 +0000
Message-ID: <54EB4FA7.3010907@linaro.org>
References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org>		
	<1421159133-31526-17-git-send-email-julien.grall@linaro.org>	
	<1424451501.30924.360.camel@citrix.com> <54E772D0.70500@linaro.org>
	<1424705515.27930.165.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YPvVd-0000gK-Bb
	for xen-devel@lists.xenproject.org; Mon, 23 Feb 2015 16:05:25 +0000
Received: by wevm14 with SMTP id m14so19486200wev.8
	for <xen-devel@lists.xenproject.org>;
	Mon, 23 Feb 2015 08:05:23 -0800 (PST)
In-Reply-To: <1424705515.27930.165.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 23/02/15 15:31, Ian Campbell wrote:
> On Fri, 2015-02-20 at 17:45 +0000, Julien Grall wrote:
>> On 20/02/15 16:58, Ian Campbell wrote:
>>> On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
>>>> This new function will correctly initialize the IOMMU page table for the
>>>> current domain.
>>>>
>>>> Also use it in iommu_assign_dt_device even though the current IOMMU
>>>> implementation on ARM shares P2M with the processor.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>>> Cc: Jan Beulich <jbeulich@suse.com>
>>>
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>> Although I'm not actually sure what it is going to be used for.
>>
>> The caller are in this patch too :) (see pci.c and device_tree.c changes).
> 
> Right, I meant "what non-trivial functionality is going to land here"
> i..e what the grandparent callers etc will eventually expect from it.

Oh ok. The function is used to the prepare the IOMMU structure for the
domain. Currently, the steps are:
	- build the page table on platforms which don't share the P2M
	- set need_iommu to 1.

Within this series, this is the only patch who touch this function.

Regards,

-- 
Julien Grall