All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	"Ewan D . Milne" <emilne@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_debug: check for bigger value first
Date: Mon, 23 Feb 2015 13:02:03 -0500	[thread overview]
Message-ID: <54EB6B1B.2050604@interlog.com> (raw)
In-Reply-To: <1420578198-24241-1-git-send-email-andy.shevchenko@gmail.com>

On 15-01-06 04:03 PM, Andy Shevchenko wrote:
> Even for signed types we have to check for bigger positive value first.
> Otherwise it will be never happened.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>

> ---
>   drivers/scsi/scsi_debug.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 8bcf6ad..a34df1d 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -4850,10 +4850,10 @@ static int __init scsi_debug_init(void)
>   	/* play around with geometry, don't waste too much on track 0 */
>   	sdebug_heads = 8;
>   	sdebug_sectors_per = 32;
> -	if (scsi_debug_dev_size_mb >= 16)
> -		sdebug_heads = 32;
> -	else if (scsi_debug_dev_size_mb >= 256)
> +	if (scsi_debug_dev_size_mb >= 256)
>   		sdebug_heads = 64;
> +	else if (scsi_debug_dev_size_mb >= 16)
> +		sdebug_heads = 32;
>   	sdebug_cylinders_per = (unsigned long)sdebug_capacity /
>   			       (sdebug_sectors_per * sdebug_heads);
>   	if (sdebug_cylinders_per >= 1024) {
>


      reply	other threads:[~2015-02-23 18:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 21:03 [PATCH] scsi_debug: check for bigger value first Andy Shevchenko
2015-02-23 18:02 ` Douglas Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EB6B1B.2050604@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.