All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: "Hatice ERTÜRK" <haticeerturk27@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Add space after '>'
Date: Mon, 23 Feb 2015 15:15:31 -0500	[thread overview]
Message-ID: <54EB8A63.80508@gmail.com> (raw)
In-Reply-To: <1424714588-24720-1-git-send-email-haticeerturk27@gmail.com>

On 02/23/15 13:03, Hatice ERTÜRK wrote:
> This Error found with checkpatch.pl
> 
> ERROR: spaces required around that '>'
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index d851675..32fbf022 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -1200,7 +1200,7 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
>  		pdata += mem_sz;
>  		data_len -= mem_sz;
>  
> -		if ((pattrib->icv_len >0) && (pattrib->bswenc)) {
> +		if ((pattrib->icv_len > 0) && (pattrib->bswenc)) {

Please provide a personalized commit message, and you can also remove
the unnecessary parenthesis' here.

Cheers,
Jes


>  			memcpy(pframe, pattrib->icv, pattrib->icv_len);
>  			pframe += pattrib->icv_len;
>  		}
> 



  reply	other threads:[~2015-02-23 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 18:03 [PATCH] Staging: rtl8723au: core: Add space after '>' Hatice ERTÜRK
2015-02-23 20:15 ` Jes Sorensen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-23 15:53 [PATCH] Staging: rtl8723au: core: Add space after '&' Hatice ERTÜRK
2015-02-23 19:24 ` [Outreachy kernel] " Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EB8A63.80508@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=haticeerturk27@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.