From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yerden Zhumabekov Subject: Re: [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent Date: Tue, 24 Feb 2015 09:00:04 +0600 Message-ID: <54EBE934.8080707@sts.kz> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <54CF0D86.3090507@sts.kz> <20150219152129.GA17032@bricha3-MOBL3> <2302266.QHkfKt2YM8@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <2302266.QHkfKt2YM8@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 23.02.2015 23:36, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > 2015-02-19 15:21, Bruce Richardson: >> Confirmed, this worked for me too. >> Looking at the patches, they look good. However, one thing I think we = are missing >> is a unit test to verify that all our CRC implementations give the sam= e result. >> That would be useful as a sanity check of the software fallback especi= ally. The >> existing hash tests, test the hash table implementation rather than th= e >> mathematical argorithm used to compute the hash values. >> >> Overall, though, software fallback for CRC is something well worthwhil= e having. >> >> Series Acked-by: Bruce Richardson > Applied, thanks > > Note: running doxygen compilation helped me to find and fix a small > mismatch (parameter alg was flag in comment). Thanks, Bruce, Thomas. As for yielding the same hash value, I made a test which runs every CRC32 implementation across a number of randomly generated data sets. Results are equal on my trial run. I can post a patch for test_hash.c a bit later if this kind of check suffices. --=20 Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ