From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbbBYUAd (ORCPT ); Wed, 25 Feb 2015 15:00:33 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:55476 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbbBYUAb (ORCPT ); Wed, 25 Feb 2015 15:00:31 -0500 X-IronPort-AV: E=Sophos;i="5.09,646,1418112000"; d="scan'208";a="58019486" Message-ID: <54EE29CF.6090208@broadcom.com> Date: Wed, 25 Feb 2015 12:00:15 -0800 From: Jonathan Richardson User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Arnd Bergmann CC: Dmitry Torokhov , Anatol Pomazau , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , , , Subject: Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour References: <1424891056-1222-2-git-send-email-jonathar@broadcom.com> <3836329.RsbZqYqPAB@wuerfel> In-Reply-To: <3836329.RsbZqYqPAB@wuerfel> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 15-02-25 11:21 AM, Arnd Bergmann wrote: > On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote: >> +- msr-override : array of strings to be used to override the individual >> + modem status signals for DCD, DSR, CTS, and RI. If the property is not >> + present, the individual signals are obtained from the modem status register. >> + Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or >> + "cts" are present, these signals will always be reported as active. If >> + "ri" is present, this signal will always be reported as inactive. >> > > Did you copy this definition from another driver? If not, we should try > to come up with a more natural way to do it. How about defining four > boolean properties instead, like > > dcd-override > dsr-override > cts-override > ri-override > > Simplifies the parser and the binding. I didn't see anything similar in another driver. I agree with the bools instead of strings. Did you want to keep these in the Synopsis driver for now or were you thinking of putting them somewhere that they could be re-used? Thanks. > > Arnd > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Richardson Subject: Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour Date: Wed, 25 Feb 2015 12:00:15 -0800 Message-ID: <54EE29CF.6090208@broadcom.com> References: <1424891056-1222-2-git-send-email-jonathar@broadcom.com> <3836329.RsbZqYqPAB@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3836329.RsbZqYqPAB@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Dmitry Torokhov , Anatol Pomazau , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Arnd, On 15-02-25 11:21 AM, Arnd Bergmann wrote: > On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote: >> +- msr-override : array of strings to be used to override the individual >> + modem status signals for DCD, DSR, CTS, and RI. If the property is not >> + present, the individual signals are obtained from the modem status register. >> + Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or >> + "cts" are present, these signals will always be reported as active. If >> + "ri" is present, this signal will always be reported as inactive. >> > > Did you copy this definition from another driver? If not, we should try > to come up with a more natural way to do it. How about defining four > boolean properties instead, like > > dcd-override > dsr-override > cts-override > ri-override > > Simplifies the parser and the binding. I didn't see anything similar in another driver. I agree with the bools instead of strings. Did you want to keep these in the Synopsis driver for now or were you thinking of putting them somewhere that they could be re-used? Thanks. > > Arnd >