From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR2wd-00075A-Qd for qemu-devel@nongnu.org; Thu, 26 Feb 2015 13:14:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR2wX-0008Ev-4C for qemu-devel@nongnu.org; Thu, 26 Feb 2015 13:13:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR2wW-0008Eh-Tx for qemu-devel@nongnu.org; Thu, 26 Feb 2015 13:13:49 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QIDlOq022146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 26 Feb 2015 13:13:47 -0500 Message-ID: <54EF625A.2060101@redhat.com> Date: Thu, 26 Feb 2015 13:13:46 -0500 From: Max Reitz MIME-Version: 1.0 References: <1424687012-18524-1-git-send-email-kraxel@redhat.com> <1424687012-18524-13-git-send-email-kraxel@redhat.com> In-Reply-To: <1424687012-18524-13-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 12/15] virtio-vga: add vgabios configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org On 2015-02-23 at 05:23, Gerd Hoffmann wrote: > Add seavgabios configuration for virtio-vga, > hook up the new vgabios in the makefiles. > > Signed-off-by: Gerd Hoffmann > --- > Makefile | 2 +- > roms/Makefile | 2 +- > roms/config.vga-virtio | 6 ++++++ > 3 files changed, 8 insertions(+), 2 deletions(-) > create mode 100644 roms/config.vga-virtio > > diff --git a/Makefile b/Makefile > index 6817c6f..cc01719 100644 > --- a/Makefile > +++ b/Makefile > @@ -337,7 +337,7 @@ bepo cz > > ifdef INSTALL_BLOBS > BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \ > -vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \ > +vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \ > acpi-dsdt.aml q35-acpi-dsdt.aml \ > ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \ > pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom \ > diff --git a/roms/Makefile b/roms/Makefile > index 610b534..c76cd5b 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -1,5 +1,5 @@ > > -vgabios_variants := stdvga cirrus vmware qxl isavga > +vgabios_variants := stdvga cirrus vmware qxl isavga virtio > vgabios_targets := $(subst -isavga,,$(patsubst %,vgabios-%.bin,$(vgabios_variants))) > pxerom_variants := e1000 eepro100 ne2k_pci pcnet rtl8139 virtio > pxerom_targets := 8086100e 80861209 10500940 10222000 10ec8139 1af41000 > diff --git a/roms/config.vga-virtio b/roms/config.vga-virtio > new file mode 100644 > index 0000000..9a78983 > --- /dev/null > +++ b/roms/config.vga-virtio > @@ -0,0 +1,6 @@ > +CONFIG_BUILD_VGABIOS=y > +CONFIG_VGA_BOCHS=y > +CONFIG_VGA_PCI=y > +CONFIG_OVERRIDE_PCI_ID=y > +CONFIG_VGA_VID=0x1af4 > +CONFIG_VGA_DID=0x1010 Will this device ID work, even with your fixups regarding the PCI device ID? Max