From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbbCEKK6 (ORCPT ); Thu, 5 Mar 2015 05:10:58 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38951 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754587AbbCEKKy (ORCPT ); Thu, 5 Mar 2015 05:10:54 -0500 Message-ID: <54F82BA8.80803@linaro.org> Date: Thu, 05 Mar 2015 10:10:48 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Paul Bolle CC: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Rob Herring , Pawel Moll , Kumar Gala , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stephen Boyd , andrew@lunn.ch, Arnd Bergmann , broonie@kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v1 5/6] eeprom: qfprom: Add Qualcomm QFPROM support. References: <1425548685-12887-1-git-send-email-srinivas.kandagatla@linaro.org> <1425548783-13110-1-git-send-email-srinivas.kandagatla@linaro.org> <1425549757.24292.204.camel@x220> In-Reply-To: <1425549757.24292.204.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thankyou for the comments, On 05/03/15 10:02, Paul Bolle wrote: > On Thu, 2015-03-05 at 09:46 +0000, Srinivas Kandagatla wrote: >> diff --git a/drivers/eeprom/Kconfig b/drivers/eeprom/Kconfig >> index bff8ecb..65325c7 100644 >> --- a/drivers/eeprom/Kconfig >> +++ b/drivers/eeprom/Kconfig >> @@ -28,4 +28,11 @@ config EEPROM_SUNXI_SID >> This driver can also be built as a module. If so, the module >> will be called sunxi_sid. >> >> +config QCOM_QFPROM >> + tristate "QCOM QFPROM Support" >> + depends on EEPROM > > Make this one tab, please. > >> + select REGMAP_MMIO >> + help >> + Say y here to enable QFPROM support. The QFPROM provides access >> + functions for QFPROM data to rest of the drivers via eeprom interface. > > And this one tab and two spaces, please. > > All utterly trivial, of course, but I found a less trivial problem with > this patch, so I included these two comments anyway. > Will fix it in next version. >> endif >> diff --git a/drivers/eeprom/Makefile b/drivers/eeprom/Makefile >> index 661422c..f99c824 100644 >> --- a/drivers/eeprom/Makefile >> +++ b/drivers/eeprom/Makefile >> @@ -8,3 +8,4 @@ obj-$(CONFIG_EEPROM) += core.o >> >> # Devices >> obj-$(CONFIG_EEPROM_SUNXI_SID) += eeprom-sunxi-sid.o >> +obj-$(CONFIG_QCOM_QFPROM) += qfprom.o >> diff --git a/drivers/eeprom/qfprom.c b/drivers/eeprom/qfprom.c >> new file mode 100644 >> index 0000000..371a8c0 >> --- /dev/null >> +++ b/drivers/eeprom/qfprom.c >> @@ -0,0 +1,74 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > [...] > >> +MODULE_LICENSE("GPL2"); > > This will taint the kernel on module load. I guess you meant > MODULE_LICENSE("GPL v2"); > > but there's no comment with some lines about the license at the top of > this file, so I can't be sure. > Yes, I meant GPL v2, and will fix the license header too in next version. --srini > > Paul Bolle > > (Chances are that by the end of this week everybody is so tired of > messages like this that people actually check this stuff before > submitting, and there's no need to review this anymore for the rest of > this year. That would be mission accomplished, I guess.) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v1 5/6] eeprom: qfprom: Add Qualcomm QFPROM support. Date: Thu, 05 Mar 2015 10:10:48 +0000 Message-ID: <54F82BA8.80803@linaro.org> References: <1425548685-12887-1-git-send-email-srinivas.kandagatla@linaro.org> <1425548783-13110-1-git-send-email-srinivas.kandagatla@linaro.org> <1425549757.24292.204.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425549757.24292.204.camel@x220> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Bolle Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maxime Ripard , Rob Herring , Pawel Moll , Kumar Gala , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Boyd , andrew-g2DYL2Zd6BY@public.gmane.org, Arnd Bergmann , broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Greg Kroah-Hartman List-Id: devicetree@vger.kernel.org Thankyou for the comments, On 05/03/15 10:02, Paul Bolle wrote: > On Thu, 2015-03-05 at 09:46 +0000, Srinivas Kandagatla wrote: >> diff --git a/drivers/eeprom/Kconfig b/drivers/eeprom/Kconfig >> index bff8ecb..65325c7 100644 >> --- a/drivers/eeprom/Kconfig >> +++ b/drivers/eeprom/Kconfig >> @@ -28,4 +28,11 @@ config EEPROM_SUNXI_SID >> This driver can also be built as a module. If so, the module >> will be called sunxi_sid. >> >> +config QCOM_QFPROM >> + tristate "QCOM QFPROM Support" >> + depends on EEPROM > > Make this one tab, please. > >> + select REGMAP_MMIO >> + help >> + Say y here to enable QFPROM support. The QFPROM provides access >> + functions for QFPROM data to rest of the drivers via eeprom interface. > > And this one tab and two spaces, please. > > All utterly trivial, of course, but I found a less trivial problem with > this patch, so I included these two comments anyway. > Will fix it in next version. >> endif >> diff --git a/drivers/eeprom/Makefile b/drivers/eeprom/Makefile >> index 661422c..f99c824 100644 >> --- a/drivers/eeprom/Makefile >> +++ b/drivers/eeprom/Makefile >> @@ -8,3 +8,4 @@ obj-$(CONFIG_EEPROM) += core.o >> >> # Devices >> obj-$(CONFIG_EEPROM_SUNXI_SID) += eeprom-sunxi-sid.o >> +obj-$(CONFIG_QCOM_QFPROM) += qfprom.o >> diff --git a/drivers/eeprom/qfprom.c b/drivers/eeprom/qfprom.c >> new file mode 100644 >> index 0000000..371a8c0 >> --- /dev/null >> +++ b/drivers/eeprom/qfprom.c >> @@ -0,0 +1,74 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > [...] > >> +MODULE_LICENSE("GPL2"); > > This will taint the kernel on module load. I guess you meant > MODULE_LICENSE("GPL v2"); > > but there's no comment with some lines about the license at the top of > this file, so I can't be sure. > Yes, I meant GPL v2, and will fix the license header too in next version. --srini > > Paul Bolle > > (Chances are that by the end of this week everybody is so tired of > messages like this that people actually check this stuff before > submitting, and there's no need to review this anymore for the rest of > this year. That would be mission accomplished, I guess.) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) Date: Thu, 05 Mar 2015 10:10:48 +0000 Subject: [PATCH v1 5/6] eeprom: qfprom: Add Qualcomm QFPROM support. In-Reply-To: <1425549757.24292.204.camel@x220> References: <1425548685-12887-1-git-send-email-srinivas.kandagatla@linaro.org> <1425548783-13110-1-git-send-email-srinivas.kandagatla@linaro.org> <1425549757.24292.204.camel@x220> Message-ID: <54F82BA8.80803@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thankyou for the comments, On 05/03/15 10:02, Paul Bolle wrote: > On Thu, 2015-03-05 at 09:46 +0000, Srinivas Kandagatla wrote: >> diff --git a/drivers/eeprom/Kconfig b/drivers/eeprom/Kconfig >> index bff8ecb..65325c7 100644 >> --- a/drivers/eeprom/Kconfig >> +++ b/drivers/eeprom/Kconfig >> @@ -28,4 +28,11 @@ config EEPROM_SUNXI_SID >> This driver can also be built as a module. If so, the module >> will be called sunxi_sid. >> >> +config QCOM_QFPROM >> + tristate "QCOM QFPROM Support" >> + depends on EEPROM > > Make this one tab, please. > >> + select REGMAP_MMIO >> + help >> + Say y here to enable QFPROM support. The QFPROM provides access >> + functions for QFPROM data to rest of the drivers via eeprom interface. > > And this one tab and two spaces, please. > > All utterly trivial, of course, but I found a less trivial problem with > this patch, so I included these two comments anyway. > Will fix it in next version. >> endif >> diff --git a/drivers/eeprom/Makefile b/drivers/eeprom/Makefile >> index 661422c..f99c824 100644 >> --- a/drivers/eeprom/Makefile >> +++ b/drivers/eeprom/Makefile >> @@ -8,3 +8,4 @@ obj-$(CONFIG_EEPROM) += core.o >> >> # Devices >> obj-$(CONFIG_EEPROM_SUNXI_SID) += eeprom-sunxi-sid.o >> +obj-$(CONFIG_QCOM_QFPROM) += qfprom.o >> diff --git a/drivers/eeprom/qfprom.c b/drivers/eeprom/qfprom.c >> new file mode 100644 >> index 0000000..371a8c0 >> --- /dev/null >> +++ b/drivers/eeprom/qfprom.c >> @@ -0,0 +1,74 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > [...] > >> +MODULE_LICENSE("GPL2"); > > This will taint the kernel on module load. I guess you meant > MODULE_LICENSE("GPL v2"); > > but there's no comment with some lines about the license at the top of > this file, so I can't be sure. > Yes, I meant GPL v2, and will fix the license header too in next version. --srini > > Paul Bolle > > (Chances are that by the end of this week everybody is so tired of > messages like this that people actually check this stuff before > submitting, and there's no need to review this anymore for the rest of > this year. That would be mission accomplished, I guess.) >