From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH iproute2] route: label externally offloaded routes Date: Sun, 08 Mar 2015 17:27:09 -0700 Message-ID: <54FCE8DD.5010005@cumulusnetworks.com> References: <1425795335-6416-1-git-send-email-sfeldma@gmail.com> <20150308065744.GB1986@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , "netdev@vger.kernel.org" , "stephen@networkplumber.org" , Jamal Hadi Salim , Andy Gospodarek To: Scott Feldman Return-path: Received: from mail-pd0-f170.google.com ([209.85.192.170]:38270 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbCIA1L (ORCPT ); Sun, 8 Mar 2015 20:27:11 -0400 Received: by pdbfl12 with SMTP id fl12so59518171pdb.5 for ; Sun, 08 Mar 2015 17:27:11 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 3/8/15, 3:10 PM, Scott Feldman wrote: > On Sun, Mar 8, 2015 at 6:35 AM, Roopa Prabhu wrote: >> >> On Sat, Mar 7, 2015 at 10:57 PM, Jiri Pirko wrote: >>> Sun, Mar 08, 2015 at 07:15:35AM CET, sfeldma@gmail.com wrote: >>>> From: Scott Feldman >>>> >>>> On ip route print dump, label externally offloaded routes with >>>> "external". >>>> Offloaded routes are flagged with RTNH_F_EXTERNAL, a recent additon to >>>> net-next. For example: >>>> >>>> $ ip route >>>> default via 192.168.0.2 dev eth0 >>>> 11.0.0.0/30 dev swp1 proto kernel scope link src 11.0.0.2 external >>>> 11.0.0.4/30 via 11.0.0.1 dev swp1 proto zebra metric 20 external >>>> 11.0.0.8/30 dev swp2 proto kernel scope link src 11.0.0.10 external >>>> 11.0.0.12/30 via 11.0.0.9 dev swp2 proto zebra metric 20 external >>>> 12.0.0.2 proto zebra metric 30 external >>>> nexthop via 11.0.0.1 dev swp1 weight 1 >>>> nexthop via 11.0.0.9 dev swp2 weight 1 >>>> 12.0.0.3 via 11.0.0.1 dev swp1 proto zebra metric 20 external >>>> 12.0.0.4 via 11.0.0.9 dev swp2 proto zebra metric 20 external >>>> 192.168.0.0/24 dev eth0 proto kernel scope link src 192.168.0.15 >>>> >>>> Signed-off-by: Scott Feldman >> No objections to the patch. >> >> since this is now getting exposed to userspace and there were suggestions in >> the past to use words like 'hw' or 'offload' in place of 'external' here, >> checking to see if you are taking suggestions. If yes, would 'hw' or >> 'offloaded' be a better name for the flag ?. > We used "external" because that's what was used for marking FDB > entries. I personally have no preference other than we be consistent > for each object offloaded externally. There will be other objects > we'll need to tag, such as bonds, so if there is enough objection to > "external", we should make the change now for FIB abd FDB objects, and > be consistent with future objects. agree, we should make the change now if needed to suite all types of object offloads. I would vote for 'hw' or 'offload' or 'hwoffload'. Thanks, Roopa