From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices Date: Mon, 09 Mar 2015 09:31:25 +0200 Message-ID: <54FD4C4D.3000607@cloudius-systems.com> References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com> <3162156.p89LbuxRO9@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <3162156.p89LbuxRO9@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 03/08/15 23:12, Thomas Monjalon wrote: > Hi Vlad, > > 2015-03-08 16:04, Vlad Zolotarov: >> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should >> be configured to the same value as HLREG0.RXCRCSTRP. >> >> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec >> but seems harmless. >> >> Signed-off-by: Vlad Zolotarov > You are mixing a fix (this patch) and enhancements (LRO) in the same series. I'd also like to clarify that I've "mixed" them because the bugs were found in the area of the enhancement therefore I united them in the same series. Frankly, I wasn't thinking about the DPDK versions it's going into when I sent the series... ;) > Could you separate them please, as LRO is not going into 2.0 but this fix > is a good candidate. > > Thanks