Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute

From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute
Date: Tue, 10 Mar 2015 08:09:29 +0300	[thread overview]
Message-ID: <54FE7C89.2030408@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425215238-25799-1-git-send-email-sw@weilnetz.de>

01.03.2015 16:07, Stefan Weil wrote:
> Warning from the Sparse static analysis tool:
> 
> disas/cris.c:1218:26: warning:
>  symbol 'cris_cond15s' was not declared. Should it be static?
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  disas/cris.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/disas/cris.c b/disas/cris.c
> index 9dfb4e3..a034dba 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -1215,7 +1215,7 @@ cris_cc_strings[] =
>  };
>  
>  /* Different names and semantics for condition 1111 (0xf).  */
> -const struct cris_cond15 cris_cond15s[] =
> +static const struct cris_cond15 cris_cond15s[] =

This is the same patch you sent 07-feb, with Message-Id:
<1423258997-30957-2-git-send-email-sw@weilnetz.de>, and
the same patch which makes at least clang unhappy:

 disas/cris.c:1218:33: error:
 unused variable 'cris_cond15s' [-Werror,-Wunused-const-variable]
 static const struct cris_cond15 cris_cond15s[] =
                                 ^
 1 error generated.

I'll drop this patch and remove the unused variable
instead.

Thanks,

/mjt