From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbbCKI3D (ORCPT ); Wed, 11 Mar 2015 04:29:03 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:39860 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbbCKI26 (ORCPT ); Wed, 11 Mar 2015 04:28:58 -0400 Message-ID: <54FFFCC7.5090707@imgtec.com> Date: Wed, 11 Mar 2015 08:28:55 +0000 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Daney , , CC: , Leonid Yegoshin , David Daney Subject: Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction" References: <1424731974-27926-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1424731974-27926-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.96] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2015 10:52 PM, David Daney wrote: > From: David Daney > > This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed. > > There are two problems: > > 1) It breaks OCTEON, which will now crash in early boot with: > > Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80) > > 2) The logic is broken. > > The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction > is required. The offending patch attempts (and fails) to change the > meaning to be that EHB is part of the ISA. > > Signed-off-by: David Daney > --- Hi, First of all sorry about the octeon breakage. However, whilst this patch will fix Octeon it will break R6 Can we please consider another patch that will simply use cpu_has_mips_r2_r6 instead of cpu_has_mips_r2 so both will work in 4.0? -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:38671 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006725AbbCKI3B4uf0E (ORCPT ); Wed, 11 Mar 2015 09:29:01 +0100 Message-ID: <54FFFCC7.5090707@imgtec.com> Date: Wed, 11 Mar 2015 08:28:55 +0000 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction" References: <1424731974-27926-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1424731974-27926-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney , linux-mips@linux-mips.org, ralf@linux-mips.org Cc: linux-kernel@vger.kernel.org, Leonid Yegoshin , David Daney Message-ID: <20150311082855.WTRinBUgoffc_7XrlKicxBOmtayX8YI43dN0DHMQoqQ@z> On 02/23/2015 10:52 PM, David Daney wrote: > From: David Daney > > This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed. > > There are two problems: > > 1) It breaks OCTEON, which will now crash in early boot with: > > Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80) > > 2) The logic is broken. > > The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction > is required. The offending patch attempts (and fails) to change the > meaning to be that EHB is part of the ISA. > > Signed-off-by: David Daney > --- Hi, First of all sorry about the octeon breakage. However, whilst this patch will fix Octeon it will break R6 Can we please consider another patch that will simply use cpu_has_mips_r2_r6 instead of cpu_has_mips_r2 so both will work in 4.0? -- markos