On 16-07-2020 19:45, Anshuman Gupta wrote:
> Sometimes LPSP test may fail due to HOTPLUG events,
> which initiates AUX transaction in order to detect a Connector
> status, these ongoing AUX transaction may fail the LPSP igt test.
> Adding a igt_wait will avoid such failures.
> Some eDP panel may have power_cycle_delay of 600ms,
> therefore 1sec delay is safer.
>
> Cc: Animesh Manna <animesh.manna@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>

LGTM.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>

> ---
>   tests/i915/i915_pm_lpsp.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index 12670f22..e9a59307 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -163,7 +163,8 @@ static void test_lpsp(data_t *data)
>   		    data->mode->vdisplay <= 2160);
>   
>   	setup_lpsp_output(data);
> -	igt_assert_f(lpsp_is_enabled(data), "%s: lpsp is not enabled\n%s:\n%s\n",
> +	igt_assert_f(igt_wait(lpsp_is_enabled(data), 1000, 100),
> +		     "%s: lpsp is not enabled\n%s:\n%s\n",
>   		     data->output->name, PWR_DOMAIN_INFO, data->pwr_dmn_info =
>   		     igt_sysfs_get(data->debugfs_fd, PWR_DOMAIN_INFO));
>   }