Re: [PATCH resend v5 05/11] ceph: add global read latency metric support

[Xiubo Li <xiubli@redhat.com>]

On 2020/2/6 4:15, Jeff Layton wrote:
> On Wed, 2020-01-29 at 03:27 -0500, xiubli@redhat.com wrote:
[...]
>> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
>> index 20e5ebfff389..0435a694370b 100644
>> --- a/fs/ceph/addr.c
>> +++ b/fs/ceph/addr.c
>> @@ -195,6 +195,7 @@ static int ceph_sync_readpages(struct ceph_fs_client *fsc,
>>   			       int page_align)
>>   {
>>   	struct ceph_osd_client *osdc = &fsc->client->osdc;
>> +	struct ceph_client_metric *metric = &fsc->mdsc->metric;
> nit: I think you can drop this variable and just dereference the metric
> field directly below where it's used. Ditto in other places where
> "metric" is only used once in the function.

Will fix them all.

>> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
>> index 141c1c03636c..101b51f9f05d 100644
>> --- a/fs/ceph/mds_client.c
>> +++ b/fs/ceph/mds_client.c
>> @@ -4182,14 +4182,29 @@ static int ceph_mdsc_metric_init(struct ceph_client_metric *metric)
>>   	atomic64_set(&metric->total_dentries, 0);
>>   	ret = percpu_counter_init(&metric->d_lease_hit, 0, GFP_KERNEL);
>>   	if (ret)
>> -		return ret;
>> +		return ret;;
> drop this, please ^^^

Will fix it.

Thanks.