Re: [PATCH] configs: j7200: correct mmc offset

["Kumar, Udit" <u-kumar1@ti.com>]

On 5/3/2023 8:15 PM, Nishanth Menon wrote:
> On 10:58-20230503, Udit Kumar wrote:
>> This patch corrects the MMC raw mode sector offset as
>> per documentation.
>>
>> https://software-dl.ti.com/jacinto7/esd/processor-sdk-linux-j7200/08_06_00_11/exports/docs/j7200/linux/Foundational_Components/U-Boot/UG-Memory.html
>>
>> Section: eMMC layout
> Please drop these TI specific documentation. Instead ADD documentation
> into u-boot source explaining these eMMC layout.

Sure,

will arch/arm/mach-k3/j7200/ place will be good to hold such documentation ?

>
> NOTE: emmc raw mode for boot partition is one way of using SPL. it is
> also very restrictive. u-boot and TIFS, OPTEE all packed into EMMC boot
> partition has limits to which it can scale.
>
> On beagle family for example, we choose this is tooo constraining and
> chose to go down a different path where the uda partition in fs mode is
> used for u-boot, tfa, optee etc.. allowing more maintainable system
> instead of having to constantly refactoring the image offsets and sizes
> involved.
>> Without this correct offset eMMC boot with UDA partition will fail.
> Where this fails is looking for the next segment of u-boot image in boot
> partition, not UDA.

Since size of tiboot3 is more than 512 Kb,

If we write whole tiboot3, then it will over write next image offset at 
0x400.

So boot will stuck for looking for tispl.bin

Restricting writing of tiboot3 to 0x400 blocks will leads to corrupt 
image of tiboot3, so nothing will start.


>> Fixes: f8c1e893c82 (configs: j7200_evm_a72: Add Initial suppot)
>> Fixes: 02dff65efe7 (configs: j7200_evm_r5: Add initial support)
>> Fixes: 360c7f46f39 (configs: Add configs for J7200 High Security EVM)
>>
>> Way to test with eMMC UDA partition
>>
>> => mmc dev 0 0
>> => fatload mmc 1 ${loadaddr} tiboot3.bin
>> => mmc write ${loadaddr} 0x0 0x800
>> => fatload mmc 1 ${loadaddr} tispl.bin
>> => mmc write ${loadaddr} 0x800 0x1000
>> => fatload mmc 1 ${loadaddr} u-boot.img
>> => mmc write ${loadaddr} 0x1800 0x2000
>> => mmc partconf 0 1 7 1
>> => mmc bootbus 0 2 0 0
>>
>> Cc: Bhavya Kapoor <b-kapoor@ti.com>
>> Cc: Diwakar Dhyani <d-dhyani@ti.com>
>> Cc: KEERTHY <j-keerthy@ti.com>
>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>>   configs/j7200_evm_a72_defconfig    | 2 +-
>>   configs/j7200_evm_r5_defconfig     | 2 +-
>>   configs/j7200_hs_evm_a72_defconfig | 2 +-
>>   configs/j7200_hs_evm_r5_defconfig  | 2 +-
>>   4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/configs/j7200_evm_a72_defconfig b/configs/j7200_evm_a72_defconfig
>> index fa5ea2aecd..8a810f8f48 100644
>> --- a/configs/j7200_evm_a72_defconfig
>> +++ b/configs/j7200_evm_a72_defconfig
>> @@ -46,7 +46,7 @@ CONFIG_SPL_STACK_R=y
>>   CONFIG_SYS_SPL_MALLOC=y
>>   CONFIG_SYS_SPL_MALLOC_SIZE=0x800000
>>   CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
>> -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x1400
>> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x1800
>>   CONFIG_SPL_DMA=y
>>   CONFIG_SPL_ENV_SUPPORT=y
>>   CONFIG_SPL_FS_LOAD_PAYLOAD_NAME="u-boot.img"
>> diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig
>> index 00ec48b83b..908cfaf402 100644
>> --- a/configs/j7200_evm_r5_defconfig
>> +++ b/configs/j7200_evm_r5_defconfig
>> @@ -43,7 +43,7 @@ CONFIG_CUSTOM_SYS_SPL_MALLOC_ADDR=0x84000000
>>   CONFIG_SYS_SPL_MALLOC_SIZE=0x1000000
>>   CONFIG_SPL_EARLY_BSS=y
>>   CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
>> -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x400
>> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x800
>>   CONFIG_SPL_DMA=y
>>   CONFIG_SPL_ENV_SUPPORT=y
>>   CONFIG_SPL_FS_EXT4=y
>> diff --git a/configs/j7200_hs_evm_a72_defconfig b/configs/j7200_hs_evm_a72_defconfig
>> index d9560727ed..c234a58a7a 100644
>> --- a/configs/j7200_hs_evm_a72_defconfig
>> +++ b/configs/j7200_hs_evm_a72_defconfig
>> @@ -47,7 +47,7 @@ CONFIG_SPL_STACK_R=y
>>   CONFIG_SYS_SPL_MALLOC=y
>>   CONFIG_SYS_SPL_MALLOC_SIZE=0x800000
>>   CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
>> -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x1400
>> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x1800
>>   CONFIG_SPL_DMA=y
>>   CONFIG_SPL_ENV_SUPPORT=y
>>   CONFIG_SPL_FS_LOAD_PAYLOAD_NAME="u-boot.img"
>> diff --git a/configs/j7200_hs_evm_r5_defconfig b/configs/j7200_hs_evm_r5_defconfig
>> index 94a6523f06..74015db1af 100644
>> --- a/configs/j7200_hs_evm_r5_defconfig
>> +++ b/configs/j7200_hs_evm_r5_defconfig
>> @@ -43,7 +43,7 @@ CONFIG_CUSTOM_SYS_SPL_MALLOC_ADDR=0x84000000
>>   CONFIG_SYS_SPL_MALLOC_SIZE=0x1000000
>>   CONFIG_SPL_EARLY_BSS=y
>>   CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
>> -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x400
>> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x800
>>   CONFIG_SPL_DMA=y
>>   CONFIG_SPL_ENV_SUPPORT=y
>>   CONFIG_SPL_FS_EXT4=y
>> -- 
>> 2.34.1
>>