From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 26 Nov 2019 04:35:00 +0100
Subject: [U-Boot] [PATCH v3 05/16] include: kernel.h: include printk.h
In-Reply-To: <20191113004502.29986-6-takahiro.akashi@linaro.org>
References: <20191113004502.29986-1-takahiro.akashi@linaro.org>
 <20191113004502.29986-6-takahiro.akashi@linaro.org>
Message-ID: <54c2a476-472c-9c28-4d23-ce3c19ee579e@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/13/19 1:44 AM, AKASHI Takahiro wrote:
> Adding "printk.h" will help improve portability from linux kernel
> code (in my case, lib/asn1_decoder.c and others) where printf and

nits:

%s/printf/printk/g

You anyway change the includes in lib/crypto/public_key.c in patch 12/16
and lib/asn1_decoder in patch 09/16. So why not add linux/printk.h there?

Otherwise I would expect this patch to remove #include <linux/printk.h>
in all files where it becomes obsolete due to this patch, e.g.

board/synopsys/hsdk/hsdk.c
arch/arm/mach-uniphier/fdt-fixup.c
arch/arm/mach-uniphier/dram_init.c
arch/arm/mach-uniphier/arm32/psci.c
arch/arm/mach-uniphier/dram/ddrphy-training.c

Best regards

Heinrich

> pr_* variant functions are used.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>   include/linux/kernel.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index 5c7e5f635b1a..564819a1c0a7 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -1,8 +1,8 @@
>   #ifndef _LINUX_KERNEL_H
>   #define _LINUX_KERNEL_H
>
> -
>   #include <linux/types.h>
> +#include <linux/printk.h> /* for printf/pr_* utilities */
>
>   #define USHRT_MAX	((u16)(~0U))
>   #define SHRT_MAX	((s16)(USHRT_MAX>>1))
>