From: Juergen Gross <jgross@suse.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Cc: David Disseldorp <ddiss@suse.de>, Hannes Reinecke <hare@suse.com>,
target-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 15/33] xen/scsiback: Fix a use-after-free
Date: Fri, 26 May 2017 11:57:09 +0200 [thread overview]
Message-ID: <54cb95f9-aeb0-7321-902e-2e816b19bcd4__14721.078091725$1495792713$gmane$org@suse.com> (raw)
In-Reply-To: <20170523234854.21452-16-bart.vanassche@sandisk.com>
On 24/05/17 01:48, Bart Van Assche wrote:
> scsiback_release_cmd() must not dereference se_cmd->se_tmr_req
> because that memory is freed by target_free_cmd_mem() before
> scsiback_release_cmd() is called. Fix this use-after-free by
> inlining struct scsiback_tmr into struct vscsibk_pend.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: David Disseldorp <ddiss@suse.de>
> Cc: xen-devel@lists.xenproject.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-26 9:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170523234854.21452-1-bart.vanassche@sandisk.com>
2017-05-23 23:48 ` [PATCH 04/33] target: Fix BYTCHK=0 handling for VERIFY and WRITE AND VERIFY commands Bart Van Assche
2017-06-02 4:15 ` Nicholas A. Bellinger
2017-06-02 16:52 ` Bart Van Assche
2017-06-03 5:32 ` Nicholas A. Bellinger
2017-06-03 5:37 ` Nicholas A. Bellinger
2017-06-05 16:49 ` Bart Van Assche
2017-06-05 22:32 ` David Butterfield
2017-06-05 23:17 ` Bart Van Assche
2017-05-23 23:48 ` [PATCH 08/33] target: Fix a deadlock between the XCOPY code and iSCSI session shutdown Bart Van Assche
2017-06-02 4:35 ` Nicholas A. Bellinger
2017-05-23 23:48 ` [PATCH 09/33] configfs: Introduce config_item_get_unless_zero() Bart Van Assche
2017-05-28 9:33 ` Christoph Hellwig
2017-05-28 16:37 ` Bart Van Assche
2017-06-13 23:22 ` Mike Christie
2017-05-23 23:48 ` [PATCH 15/33] xen/scsiback: Fix a use-after-free Bart Van Assche
2017-05-23 23:48 ` [PATCH 16/33] xen/scsiback: Replace a waitqueue and a counter by a completion Bart Van Assche
2017-05-23 23:48 ` [PATCH 17/33] xen/scsiback: Make TMF processing slightly faster Bart Van Assche
2017-05-23 23:48 ` [PATCH 25/33] target/iscsi: Avoid overflowing the receive buffer Bart Van Assche
2017-05-23 23:48 ` [PATCH 29/33] target/iscsi: Simplify timer manipulation code Bart Van Assche
[not found] ` <20170523234854.21452-16-bart.vanassche@sandisk.com>
2017-05-26 9:57 ` Juergen Gross [this message]
2017-06-03 5:40 ` [PATCH 15/33] xen/scsiback: Fix a use-after-free Nicholas A. Bellinger
[not found] ` <1496468455.27407.305.camel@haakon3.risingtidesystems.com>
2017-06-03 7:04 ` Nicholas A. Bellinger
[not found] ` <1496473471.27407.317.camel@haakon3.risingtidesystems.com>
2017-06-03 7:06 ` Juergen Gross
[not found] ` <20170523234854.21452-17-bart.vanassche@sandisk.com>
2017-05-26 10:13 ` [PATCH 16/33] xen/scsiback: Replace a waitqueue and a counter by a completion Juergen Gross
2017-06-03 5:41 ` Nicholas A. Bellinger
[not found] ` <20170523234854.21452-18-bart.vanassche@sandisk.com>
2017-05-26 10:18 ` [PATCH 17/33] xen/scsiback: Make TMF processing slightly faster Juergen Gross
2017-06-03 5:41 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='54cb95f9-aeb0-7321-902e-2e816b19bcd4__14721.078091725$1495792713$gmane$org@suse.com' \
--to=jgross@suse.com \
--cc=bart.vanassche@sandisk.com \
--cc=ddiss@suse.de \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.