From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [PATCH V11 1/3] eal: add uevent monitor api and
 callback func
Date: Thu, 18 Jan 2018 12:23:50 +0800
Message-ID: <54cdd881-2482-242b-c4a3-867c28d14223@intel.com>
References: <1515679534-22473-2-git-send-email-jia.guo@intel.com>
 <1516013331-18939-1-git-send-email-jia.guo@intel.com>
 <10337288.PlhJV8PepH@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, gaetan.rivet@6wind.com,
 konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com,
 jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 3F0EF1B1BE
 for <dev@dpdk.org>; Thu, 18 Jan 2018 05:23:53 +0100 (CET)
In-Reply-To: <10337288.PlhJV8PepH@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 1/18/2018 5:59 AM, Thomas Monjalon wrote:
> 15/01/2018 11:48, Jeff Guo:
>> + * It registers the callback for the specific event. Multiple
>> + * callbacks cal be registered at the same time.
>> + *
>> + * @param device_name
>> + *  The device name.
>> + * @param cb_fn
>> + *  callback address.
>> + * @param cb_arg
>> + *  address of parameter for callback.
>> + *
>> + * @return
>> + *  - On success, zero.
>> + *  - On failure, a negative value.
>> + */
>> +int rte_dev_callback_register(char *device_name, rte_dev_event_cb_fn cb_fn,
>> +                                       void *cb_arg);
> What is the device name?
>
> I think we should register a callback for a rte_device or NULL (all devices).
please see my v12 patch, the device name have been info to user.
i think a device name for a callback might be fulfill , since if use 
NULL for all device, a callback could not belong to a NULL point. if 
there are any advantage by callback for a rte_device, please explicit 
outline it. and i think it must be a improvement  and anyway if need i 
will try to make it better.
and what ever a callback for a rte_device or a device name for a 
callback, i think that is not our gap, i guess what you care about is 
that the new and firstly hot plug in device monitor , so i would add 
null check for identify these new device callback. am i right?