Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection

From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ray Kinsella <mdr@ashroe.eu>,
	Ferruh Yigit <ferruh.yigit@xilinx.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Andrew Boyer <aboyer@pensando.io>,
	Beilei Xing <beilei.xing@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Chas Williams <chas3@att.com>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	Ciara Loftus <ciara.loftus@intel.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Gaetan Rivet <grive@u256.net>, Gagandeep Singh <g.singh@nxp.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	Haiyue Wang <haiyue.wang@intel.com>,
	Harman Kalra <hkalra@marvell.com>,
	heinrich.kuhn@corigine.com,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	Igor Chauskin <igorch@amazon.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Jakub Grajciar <jgrajcia@cisco.com>,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Jian Wang <jianwang@trustnetic.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	John Daley <johndale@cisco.com>,
	John Miller <john.miller@atomicrules.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Wiles, Keith" <keith.wiles@intel.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Lijun Ou <oulijun@huawei.com>, Liron Himi <lironh@marvell.com>,
	Long Li <longli@microsoft.com>, Marcin Wojtas <mw@semihalf.com>,
	Martin Spinler <spinler@cesnet.cz>,
	Matan Azrad <matan@nvidia.com>,
	Matt Peters <matt.peters@windriver.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Michal Krawczyk <mk@semihalf.com>,
	"Min Hu (Connor" <humin29@huawei.com>,
	Pradeep Kumar Nalla <pnalla@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Radha Mohan Chintakuntla <radhac@marvell.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Rasesh Mody <rmody@marvell.com>, Rosen Xu <rosen.xu@intel.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
	Shahed Shaikh <shshaikh@marvell.com>,
	Shai Brandes <shaibran@amazon.com>,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	Somalapuram Amaranath <asomalap@amd.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Steven Webster <steven.webster@windriver.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	Veerasenareddy Burru <vburru@marvell.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Xiao Wang <xiao.w.wang@intel.com>,
	Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Yong Wang <yongwang@vmware.com>,
	Ziyang Xuan <xuanziyang2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection
Date: Thu, 19 May 2022 10:05:11 +0300	[thread overview]
Message-ID: <54d4a40d-097e-584f-28ff-09d8738aab7b@oktetlabs.ru> (raw)
In-Reply-To: <CALBAE1PiUr0b0FPJ7dAayL=E-x1TAcHdh+q_Z8NsKLSVc+GY2A@mail.gmail.com>

On 5/12/22 14:03, Jerin Jacob wrote:
> On Thu, May 12, 2022 at 1:06 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Hi Jerin,
> 
> Hi Andrew,
> 
>>
>> On 5/1/22 17:46, jerinj@marvell.com wrote:
>>> From: Jerin Jacob <jerinj@marvell.com>
>>>
>>> Currently, meter object supports only DSCP based on input color table,
>>> The patch enhance that to support VLAN based input color table,
>>> color table based on inner field for the tunnel use case, and
>>> support for fallback color per meter if packet based on a different field.
>>>
>>> All of the above features are exposed through capability and added
>>> additional capability to specify the implementation supports
>>> more than one input color table per ethdev port.
>>>
>>> Suggested-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>
>> the patch LGTM, but I have a couple of questions to clarify:
>>
>> 1. Will we have API usage patches in the release cycle (I guess
>>      testpmd)?
>>
>> 2. Will we have net driver patches which add support for
>>      new driver callbacks and advertise added capabilities?
> 
> Yes. Both will be there for this release. Most likely post rc1.
> 
> We have testpmd, cnxk driver changes for the v1 version of the
> spec[1]. We will update both for the latest spec version.(We just
> awaiting for spec to merge)
> 
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-3-skori@marvell.com/
> https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-2-skori@marvell.com/
> 
>>
>> Thanks,
>> Andrew.

Applied, thanks.