All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: hush_if_test: Add tests to cover octal/hex values
Date: Fri, 11 Oct 2019 08:50:15 +0200	[thread overview]
Message-ID: <54db2685-3437-eed8-73fa-63d95a59b3ea@xilinx.com> (raw)
In-Reply-To: <CAPnjgZ0kAj_shhbJ-=RP1Q6HRCWxCnyXMBt7-BFSbK-MYT7_4A@mail.gmail.com>

On 10. 10. 19 19:06, Simon Glass wrote:
> Hi Michal,
> 
> On Thu, 10 Oct 2019 at 05:44, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> Extend test suite to cover also automatic octal/hex converstions which
>> haven't been implemented in past.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Depends on https://lists.denx.de/pipermail/u-boot/2019-September/383309.html
>>
>> There are of course other tests which we can run but not sure if make sense
>> to have there all combinations. The most interesting are mixed tests which
>> are failing before patch above is applied.
>> Definitely please let me know if you want to add any other test.
>> ---
>>  test/py/tests/test_hush_if_test.py | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
> 
> I worry that these tests might be very slow since it requires a lot of
> interaction with U-Boot over a pipe. Is it possible to put them in C
> code instead, e.g. cmd_ut?

I have of course running it on my HW and it is quite fast. It is just 16
more simple tests. And if this breaks gitlab/travis CI loops then we
have bigger problem.
I see that CONFIG_UNIT_TEST is enabled only for sandbox. Do it make
sense to enable it also for others to have better coverage?

Thanks,
Michal

  reply	other threads:[~2019-10-11  6:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 11:44 [U-Boot] [PATCH] test/py: hush_if_test: Add tests to cover octal/hex values Michal Simek
2019-10-10 15:56 ` Stephen Warren
2019-10-10 16:40   ` Simon Goldschmidt
2019-10-10 17:06 ` Simon Glass
2019-10-11  6:50   ` Michal Simek [this message]
2019-10-11 15:53     ` Simon Glass
2019-10-15  6:08       ` Michal Simek
2019-10-21 22:53         ` Simon Glass
2019-10-21 23:04           ` Stephen Warren
2019-10-21 23:46             ` Simon Glass
2019-10-22 15:54               ` Stephen Warren
2019-10-24  6:50                 ` Michal Simek
2019-10-30  1:48                   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54db2685-3437-eed8-73fa-63d95a59b3ea@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.