From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3764FC4361A for ; Fri, 4 Dec 2020 22:58:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8597222D01 for ; Fri, 4 Dec 2020 22:58:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8597222D01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klK1X-0007H3-Le for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 17:57:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klJyR-0005zi-Fd for qemu-devel@nongnu.org; Fri, 04 Dec 2020 17:54:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1klJyP-0000Rq-4I for qemu-devel@nongnu.org; Fri, 04 Dec 2020 17:54:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607122483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3+gl4WdbPtXKsRICXKxPE7bk2EupajiaPiAoXQa8RE=; b=Si9b+Q4Djw/FgqeY+t/jyqjf9HvG5aW4zkFxhfagnQcigN4q1g4zLV0AnlacgSdQkpP6DV iPqlfYk09reqRiGVsCv0nspYI2hRQ5c8EbQxHUww3y9Ypf9A+BrabGhWg6n7q2e5yk5hrX YQ7ew4hBCmYnVO8/zB3kzxvgnWx91bA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-FCF1_NG5PxK65nDeFtTnwg-1; Fri, 04 Dec 2020 17:54:40 -0500 X-MC-Unique: FCF1_NG5PxK65nDeFtTnwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E654A80ED9B; Fri, 4 Dec 2020 22:54:38 +0000 (UTC) Received: from [10.3.112.195] (ovpn-112-195.phx2.redhat.com [10.3.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51B6160C04; Fri, 4 Dec 2020 22:54:24 +0000 (UTC) Subject: Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND To: Markus Armbruster References: <20201113011340.463563-1-eblake@redhat.com> <20201113011340.463563-8-eblake@redhat.com> <871rgpg27o.fsf@dusky.pond.sub.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <54de873e-53df-8ed8-291b-d0d17a96d057@redhat.com> Date: Fri, 4 Dec 2020 16:54:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <871rgpg27o.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:GLUSTER" , Eduardo Habkost , "open list:GLUSTER" , "Michael S. Tsirkin" , Jason Wang , Juan Quintela , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Igor Mammedov , Michael Roth , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/19/20 2:50 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> +++ b/hw/core/machine-qmp-cmds.c > [...] >> @@ -294,41 +281,31 @@ void qmp_set_numa_node(NumaOptions *cmd, Error **errp) >> static int query_memdev(Object *obj, void *opaque) >> v = qobject_input_visitor_new(host_nodes); >> - visit_type_uint16List(v, NULL, &m->value->host_nodes, &error_abort); >> + visit_type_uint16List(v, NULL, &m->host_nodes, &error_abort); >> visit_free(v); >> qobject_unref(host_nodes); >> >> - m->next = *list; >> - *list = m; >> + QAPI_LIST_APPEND(list, m); > > The old code prepends, doesn't it? Good catch, will correct and hoist this into 4/7 for v3. > >> } >> >> return 0; >> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c >> index cf0627fd01c1..1afcc29a0649 100644 >> --- a/hw/mem/memory-device.c >> +++ b/hw/mem/memory-device.c >> @@ -199,7 +199,7 @@ out: >> MemoryDeviceInfoList *qmp_memory_device_list(void) >> { >> GSList *devices = NULL, *item; >> - MemoryDeviceInfoList *list = NULL, *prev = NULL; >> + MemoryDeviceInfoList *list = NULL, **prev = &list; > > Here, you reuse the old name for the new variable. >> +++ b/hw/pci/pci.c >> @@ -1681,41 +1681,34 @@ static PciDeviceInfoList *qmp_query_pci_devices(PCIBus *bus, int bus_num); >> >> static PciMemoryRegionList *qmp_query_pci_regions(const PCIDevice *dev) >> { >> - PciMemoryRegionList *head = NULL, *cur_item = NULL; >> + PciMemoryRegionList *head = NULL, **tail = &head; > > Here, you use a new and better name. > > I'd like to encourage you to name tail pointer variables @tail > elsewhere, too. In v3, I will consistently rename the FOOList ** variable 'tail'. >> @@ -2863,7 +2846,6 @@ qmp_guest_set_memory_blocks(GuestMemoryBlockList *mem_blks, Error **errp) >> >> while (mem_blks != NULL) { >> GuestMemoryBlockResponse *result; >> - GuestMemoryBlockResponseList *entry; >> GuestMemoryBlock *current_mem_blk = mem_blks->value; >> >> result = g_malloc0(sizeof(*result)); >> @@ -2872,11 +2854,7 @@ qmp_guest_set_memory_blocks(GuestMemoryBlockList *mem_blks, Error **errp) >> if (local_err) { /* should never happen */ >> goto err; >> } >> - entry = g_malloc0(sizeof *entry); >> - entry->value = result; >> - >> - *link = entry; >> - link = &entry->next; >> + QAPI_LIST_APPEND(link, result); >> mem_blks = mem_blks->next; >> } >> > > This one looks like a candidate for PATCH 6. Yes. Will hoist. v3 will be posted soon. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org