* [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail
@ 2021-09-08 9:28 Bixuan Cui
2021-09-08 16:43 ` Dave Jiang
2021-10-25 6:37 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-09-08 9:28 UTC (permalink / raw)
To: linux-kernel, dmaengine; +Cc: dave.jiang, vkoul, john.wanghui
Using list_move_tail() instead of list_del() + list_add_tail()
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/dma/idxd/irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index ca88fa7a328e..79fcfc4883e4 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
if (desc->completion->status) {
- list_del(&desc->list);
- list_add_tail(&desc->list, &flist);
+ list_move_tail(&desc->list, &flist);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail
2021-09-08 9:28 [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail Bixuan Cui
@ 2021-09-08 16:43 ` Dave Jiang
2021-10-25 6:37 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2021-09-08 16:43 UTC (permalink / raw)
To: Bixuan Cui, linux-kernel, dmaengine; +Cc: vkoul, john.wanghui
On 9/8/2021 2:28 AM, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Thanks!
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index ca88fa7a328e..79fcfc4883e4 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
>
> list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
> if (desc->completion->status) {
> - list_del(&desc->list);
> - list_add_tail(&desc->list, &flist);
> + list_move_tail(&desc->list, &flist);
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail
2021-09-08 9:28 [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail Bixuan Cui
2021-09-08 16:43 ` Dave Jiang
@ 2021-10-25 6:37 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-10-25 6:37 UTC (permalink / raw)
To: Bixuan Cui; +Cc: linux-kernel, dmaengine, dave.jiang, john.wanghui
On 08-09-21, 17:28, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 9:28 [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail Bixuan Cui
2021-09-08 16:43 ` Dave Jiang
2021-10-25 6:37 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.