From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F25C32750 for ; Fri, 2 Aug 2019 10:23:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D9D120665 for ; Fri, 2 Aug 2019 10:23:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t+tzWKhU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D9D120665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xOzDae5OSx4VU1m8z+dVBUMPtI02xL9WspnNxntbA54=; b=t+tzWKhUrEw7cQ/kGQJIEUA2G 3IHBidg1ziALJFqKnsK2DQPoetnHZcwuIUXrIiueopAxJL0WH6Q7BXNKmZDxOuL9tYmjioDA02az1 aq2FeaBtDQP0J9LIZIVHGTqLapvOxyn9CvDcTPirfPqLQh2TDEVUGbNdgk7KDAMWAHYpcdGAJMMes o1ZDHKZrQNZzFbdDW1V/bRGJS+QSDCyURLFqTffHkuzPkvDsAw8SAiaNqJpHX4ZZr6jrCD5pvDPmF zMvwBhzYfriRPe9yqzuquTdjNP+LHXun7NSg+yQKzEYzYDgB3yJCFSXo/cYLP0g0Ew/b7xhzoiyU6 e4Z4YHRxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htUiT-0005oO-Ss; Fri, 02 Aug 2019 10:23:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htUiQ-0005nz-5L for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2019 10:23:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B09A344; Fri, 2 Aug 2019 03:23:12 -0700 (PDT) Received: from dawn-kernel.cambridge.arm.com (unknown [10.1.197.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 19F583F71F; Fri, 2 Aug 2019 03:23:10 -0700 (PDT) Subject: Re: [PATCH v4 3/6] coresight: etm4x: use module_param instead of module_param_named To: andrew.murray@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com References: <20190730125157.884-1-andrew.murray@arm.com> <20190730125157.884-4-andrew.murray@arm.com> From: Suzuki K Poulose Message-ID: <54e6c265-af92-ea58-1ce6-c426996c906a@arm.com> Date: Fri, 2 Aug 2019 11:23:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190730125157.884-4-andrew.murray@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190802_032314_244732_363A2CE7 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al.Grant@arm.com, coresight@lists.linaro.org, leo.yan@linaro.org, Sudeep.Holla@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2019 13:51, Andrew Murray wrote: > Given that the user-exposed module parameter for 'boot_enable' matches > the variable that it sets, let's use module_param instead of > module_param_named. > > Let's also use octal permissions (checkpatch recommends this) and > provide a module parameter description. > > Signed-off-by: Andrew Murray > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index ec9468880c71..615bdbf7c9b7 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -34,7 +34,8 @@ > #include "coresight-etm-perf.h" > > static int boot_enable; > -module_param_named(boot_enable, boot_enable, int, S_IRUGO); > +module_param(boot_enable, int, 0444); > +MODULE_PARM_DESC(boot_enable, "Enable tracing on boot"); > > /* The number of ETMv4 currently registered */ > static int etm4_count; > Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel