From: "Liang He" <windhl@126.com>
To: "Peter Rosin" <peda@axentia.se>
Cc: linux-i2c@vger.kernel.org
Subject: Re:Re: [PATCH] i2c: i2c-mux-gpmux: Add of_node_put() when breaking out of loop
Date: Fri, 22 Jul 2022 09:14:19 +0800 (CST) [thread overview]
Message-ID: <54fa5ea2.b3c.18223783e5d.Coremail.windhl@126.com> (raw)
In-Reply-To: <ccfb8195-7517-aad7-6b59-c0af7652e5a5@axentia.se>
At 2022-07-21 17:20:56, "Peter Rosin" <peda@axentia.se> wrote:
>Hi!
>
>2022-07-21 at 10:12, Liang He wrote:
>> In i2c_mux_probe(), we should call of_node_put() when breaking out
>> of for_each_child_of_node() which will automatically increase and
>> decrease the refcount.
>>
>> Fixes: ac8498f0ce53 ("i2c: i2c-mux-gpmux: new driver")
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> drivers/i2c/muxes/i2c-mux-gpmux.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
>> index d3acd8d66c32..30ab2fe88c8d 100644
>> --- a/drivers/i2c/muxes/i2c-mux-gpmux.c
>> +++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
>> @@ -115,6 +115,7 @@ static int i2c_mux_probe(struct platform_device *pdev)
>> if (ret < 0) {
>> dev_err(dev, "no reg property for node '%pOFn'\n",
>> child);
>> + of_node_put(child);
>> goto err_children;
>> }
>>
>
>Right, but this is obviously incomplete. What about the other two branches
>in that loop that breaks out?
>
>Much better to have the missing of_node_put(child) statement below the
>err_children: label (i.e. before i2c_mux_del_adapters) so that it is not
>forgotten in any code flow. child cannot be uninitialized at that point
>and if it happens to be NULL, of_node_put will be a nop. So that's safe.
>
>Cheers,
>Peter
Thanks, Peter,
I have forgotten add of_node_put() in other fail path.
But your advice is better, I will send a new version soon!
Thanks again,
Liang
prev parent reply other threads:[~2022-07-22 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 8:12 [PATCH] i2c: i2c-mux-gpmux: Add of_node_put() when breaking out of loop Liang He
2022-07-21 9:20 ` Peter Rosin
2022-07-22 1:14 ` Liang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54fa5ea2.b3c.18223783e5d.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.