From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbbCKRFG (ORCPT ); Wed, 11 Mar 2015 13:05:06 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54800 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbbCKRE7 (ORCPT ); Wed, 11 Mar 2015 13:04:59 -0400 Message-ID: <550075B8.7060208@osg.samsung.com> Date: Wed, 11 Mar 2015 11:04:56 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: John Stultz CC: Linux Kernel Mailing List , Prarit Bhargava , Thomas Gleixner , Richard Cochran Subject: Re: [PATCH 00/19 v3] Add timekeeping tests to kernel selftest References: <1425330612-24280-1-git-send-email-john.stultz@linaro.org> <550070CC.9090007@osg.samsung.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 10:53 AM, John Stultz wrote: > On Wed, Mar 11, 2015 at 9:43 AM, Shuah Khan wrote: >> On 03/02/2015 02:09 PM, John Stultz wrote: >>> I've hosted my timekeeping tests on github for the last few years: >>> https://github.com/johnstultz-work/timetests >>> >>> but I suspect not too many folks have actually used them. >>> >>> I've been meaning to get them reworked and submitted into the >>> selftest infrastructure, but haven't had much time until >>> recently. >>> >>> I've added both the non-desctructive and destructive tests >>> (which set the time, possibly to strange values, or tries >>> to trigger historical issues that could crash the machine). >>> The destructive tests are run (as root, or with proper >>> privledge) via: >>> # make run_destructive_tests >>> >>> Changes in v3: >>> * Lots of -Wall build warning fixups >>> * Handle the CROSS_COMPILER build variable properly >>> (Thanks to LinusW for pointing that out) >>> * Integrate w/ ksft_exit_* infrastructure >>> >>> Let me know if there is any further comments or feedback! >>> >> >> Ran into several checkpatch warnings when I tried to queue >> these up for 4.1. Could you please fix them and resend. > > So the only few items I saw were: > 1) Lines over 80 col, usually do to long string output > 2) String output split over multiple lines (result of trying to fix #1 > in a few spots) > - And here I did try to split the string sanely so I didn't break > up the messages, so they're still grepable > 3) The extern char *optarg, warning. This one I can probably kill > since I'm including unistd.h. > > I'll take a look at #3, but #1 and #2 are basically contrary at a > certain point. Or do you have other ideas for resolving those > warnings? Here are the errors git am flagged: Patch07: Applying: selftests/timers: Add set-timer-lat test from timetest suite /lkml/linux_4.0/.git/rebase-apply/patch:246: new blank line at EOF. + warning: 1 line adds whitespace errors. Patch11 Applying: selftests/timers: Add alarmtimer-suspend test from timetests suite /lkml/linux_4.0/.git/rebase-apply/patch:222: new blank line at EOF. + warning: 1 line adds whitespace errors. Patch18 Applying: selftests/timers: Add set-2038 test from timetest suite /lkml/linux_4.0/.git/rebase-apply/patch:180: new blank line at EOF. + warning: 1 line adds whitespace errors. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978