From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v10 16/21] irqchip: Add GICv2 specific ACPI boot support Date: Thu, 12 Mar 2015 15:31:57 +0800 Message-ID: <550140ED.3080808@huawei.com> References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <1426077587-1561-17-git-send-email-hanjun.guo@linaro.org> <20150311231141.GG21998@io.lakedaemon.net> <5500EFFF.2070807@huawei.com> <20150312051245.GI21998@io.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150312051245.GI21998@io.lakedaemon.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jason Cooper Cc: Mark Rutland , linaro-acpi , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Timur Tabi , ACPI Devel Mailing List , Grant Likely , Robert Richter , Arnd Bergmann , Marc Zyngier , Jon Masters , Tomasz Nowicki , Mark Brown , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Graeme Gregory , Ashwin Chaugule , "Rafael J. Wysocki" , Linux Kernel Mailing List , Hanjun Guo , Suravee Suthikulanit List-Id: linux-acpi@vger.kernel.org On 2015/3/12 13:12, Jason Cooper wrote: > On Thu, Mar 12, 2015 at 09:46:39AM +0800, Hanjun Guo wrote: >> On 2015/3/12 7:11, Jason Cooper wrote: >>> Hey Grant, >>> >>> On Wed, Mar 11, 2015 at 06:04:50PM +0000, Grant Likely wrote: >>>> On 11 Mar 2015 12:42, "Hanjun Guo" wrote: [...] >>>>> diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c >>>>> index 0fe2f71..afd1af3 100644 >>>>> --- a/drivers/irqchip/irqchip.c >>>>> +++ b/drivers/irqchip/irqchip.c >>>>> @@ -8,6 +8,7 @@ >>>>> * warranty of any kind, whether express or implied. >>>>> */ >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> #include >>>>> @@ -26,4 +27,6 @@ extern struct of_device_id __irqchip_of_table[]; >>>>> void __init irqchip_init(void) >>>>> { >>>>> of_irq_init(__irqchip_of_table); >>>>> + >>>>> + acpi_irq_init(); >>>>> } >>> Is this in line with Olof's idea that providing a dtb would override ACPI? >> Yes, it will. Since ACPI is default OFF (disabled), if a dtb provided, and no acpi=force >> passed in the early command line, dtb will be used as system configuration for >> boot (dtb is always the prior one for now) [1]. In acpi_gic_init() which called by >> acpi_irq_init(), it will return immediately if acpi disabled, so it will not parse >> any ACPI table for device configuration. > Ok, that matches my recollection. Thanks for refreshing my memory. I'll apply > this on a topic branch for irqchip/gic when I return from travel. Most likely > Friday or over the weekend. Thank you very much! But this patch can't be applied without previous ones in this patch set, how about you ack this patch and Catalin takes it via ARM64 tree? I'm not sure for this, it depends on your decision. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbbCLHfv (ORCPT ); Thu, 12 Mar 2015 03:35:51 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:20152 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbbCLHfs (ORCPT ); Thu, 12 Mar 2015 03:35:48 -0400 Message-ID: <550140ED.3080808@huawei.com> Date: Thu, 12 Mar 2015 15:31:57 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Jason Cooper CC: Grant Likely , Mark Rutland , linaro-acpi , "Catalin Marinas" , Will Deacon , "Lorenzo Pieralisi" , Timur Tabi , ACPI Devel Mailing List , Robert Richter , Arnd Bergmann , Marc Zyngier , Jon Masters , Tomasz Nowicki , Mark Brown , Thomas Gleixner , , Graeme Gregory , Ashwin Chaugule , "Rafael J. Wysocki" , Linux Kernel Mailing List , Hanjun Guo , "Suravee Suthikulanit" , Sudeep Holla , Olof Johansson Subject: Re: [PATCH v10 16/21] irqchip: Add GICv2 specific ACPI boot support References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <1426077587-1561-17-git-send-email-hanjun.guo@linaro.org> <20150311231141.GG21998@io.lakedaemon.net> <5500EFFF.2070807@huawei.com> <20150312051245.GI21998@io.lakedaemon.net> In-Reply-To: <20150312051245.GI21998@io.lakedaemon.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/12 13:12, Jason Cooper wrote: > On Thu, Mar 12, 2015 at 09:46:39AM +0800, Hanjun Guo wrote: >> On 2015/3/12 7:11, Jason Cooper wrote: >>> Hey Grant, >>> >>> On Wed, Mar 11, 2015 at 06:04:50PM +0000, Grant Likely wrote: >>>> On 11 Mar 2015 12:42, "Hanjun Guo" wrote: [...] >>>>> diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c >>>>> index 0fe2f71..afd1af3 100644 >>>>> --- a/drivers/irqchip/irqchip.c >>>>> +++ b/drivers/irqchip/irqchip.c >>>>> @@ -8,6 +8,7 @@ >>>>> * warranty of any kind, whether express or implied. >>>>> */ >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> #include >>>>> @@ -26,4 +27,6 @@ extern struct of_device_id __irqchip_of_table[]; >>>>> void __init irqchip_init(void) >>>>> { >>>>> of_irq_init(__irqchip_of_table); >>>>> + >>>>> + acpi_irq_init(); >>>>> } >>> Is this in line with Olof's idea that providing a dtb would override ACPI? >> Yes, it will. Since ACPI is default OFF (disabled), if a dtb provided, and no acpi=force >> passed in the early command line, dtb will be used as system configuration for >> boot (dtb is always the prior one for now) [1]. In acpi_gic_init() which called by >> acpi_irq_init(), it will return immediately if acpi disabled, so it will not parse >> any ACPI table for device configuration. > Ok, that matches my recollection. Thanks for refreshing my memory. I'll apply > this on a topic branch for irqchip/gic when I return from travel. Most likely > Friday or over the weekend. Thank you very much! But this patch can't be applied without previous ones in this patch set, how about you ack this patch and Catalin takes it via ARM64 tree? I'm not sure for this, it depends on your decision. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: guohanjun@huawei.com (Hanjun Guo) Date: Thu, 12 Mar 2015 15:31:57 +0800 Subject: [PATCH v10 16/21] irqchip: Add GICv2 specific ACPI boot support In-Reply-To: <20150312051245.GI21998@io.lakedaemon.net> References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <1426077587-1561-17-git-send-email-hanjun.guo@linaro.org> <20150311231141.GG21998@io.lakedaemon.net> <5500EFFF.2070807@huawei.com> <20150312051245.GI21998@io.lakedaemon.net> Message-ID: <550140ED.3080808@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/3/12 13:12, Jason Cooper wrote: > On Thu, Mar 12, 2015 at 09:46:39AM +0800, Hanjun Guo wrote: >> On 2015/3/12 7:11, Jason Cooper wrote: >>> Hey Grant, >>> >>> On Wed, Mar 11, 2015 at 06:04:50PM +0000, Grant Likely wrote: >>>> On 11 Mar 2015 12:42, "Hanjun Guo" wrote: [...] >>>>> diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c >>>>> index 0fe2f71..afd1af3 100644 >>>>> --- a/drivers/irqchip/irqchip.c >>>>> +++ b/drivers/irqchip/irqchip.c >>>>> @@ -8,6 +8,7 @@ >>>>> * warranty of any kind, whether express or implied. >>>>> */ >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> #include >>>>> @@ -26,4 +27,6 @@ extern struct of_device_id __irqchip_of_table[]; >>>>> void __init irqchip_init(void) >>>>> { >>>>> of_irq_init(__irqchip_of_table); >>>>> + >>>>> + acpi_irq_init(); >>>>> } >>> Is this in line with Olof's idea that providing a dtb would override ACPI? >> Yes, it will. Since ACPI is default OFF (disabled), if a dtb provided, and no acpi=force >> passed in the early command line, dtb will be used as system configuration for >> boot (dtb is always the prior one for now) [1]. In acpi_gic_init() which called by >> acpi_irq_init(), it will return immediately if acpi disabled, so it will not parse >> any ACPI table for device configuration. > Ok, that matches my recollection. Thanks for refreshing my memory. I'll apply > this on a topic branch for irqchip/gic when I return from travel. Most likely > Friday or over the weekend. Thank you very much! But this patch can't be applied without previous ones in this patch set, how about you ack this patch and Catalin takes it via ARM64 tree? I'm not sure for this, it depends on your decision. Thanks Hanjun