From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 12 Mar 2015 09:39:50 +0100
Subject: [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting
 via SHA256 encrypted password
In-Reply-To: <20150311143646.GL32541@bill-the-cat>
References: <1426063900-7267-1-git-send-email-sr@denx.de>
 <20150311143646.GL32541@bill-the-cat>
Message-ID: <550150D6.9090003@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On 11.03.2015 15:36, Tom Rini wrote:
> On Wed, Mar 11, 2015 at 09:51:37AM +0100, Stefan Roese wrote:
>
>> This patch adds the feature to only stop the autobooting, and therefor
>> boot into the U-Boot prompt, when the input string / password matches
>> a values that is encypted via a SHA256 hash and saved in the environment.
>>
>> This feature is enabled by defined these config options:
>>       CONFIG_AUTOBOOT_KEYED
>>       CONFIG_AUTOBOOT_STOP_STR_SHA256
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>
> This is certainly interesting but I think brings us back to a point
> Simon made a long while back about needing to factor out this code
> better.  Especially since this adds big long #if-#else-#endif blocks.
> Can we re-do this so at least have some functions be called out instead?

Yes, I'll try to rework this patch a bit to make this feature 
integration less ugly.

Thanks,
Stefan