From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbbCLJcq (ORCPT ); Thu, 12 Mar 2015 05:32:46 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36975 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbCLJco (ORCPT ); Thu, 12 Mar 2015 05:32:44 -0400 Message-ID: <55015D38.5060100@gmail.com> Date: Thu, 12 Mar 2015 10:32:40 +0100 From: Quentin Lambert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dan Carpenter , =?UTF-8?B?R2llZHJpdXMgU3RhdA==?= =?UTF-8?B?a2V2acSNaXVz?= CC: Lidza Louina , Mark Hounschell , Greg Kroah-Hartman , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling References: <20150311140433.GA17051@sloth> <55006F4A.70805@gmail.com> <20150312092711.GX10964@mwanda> In-Reply-To: <20150312092711.GX10964@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2015 10:27, Dan Carpenter wrote: > On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote: >> It's still not in staging-testing for some reason :( >> > It can take several weeks to get merged. Relax. > > regards, > dan carpenter > What should i do concerning that ? I need to send a second version of this patch anyway to fix the fact that i inverted 2 statements, namely: +exit_unlock: + if (ld) + tty_ldisc_deref(ld); + spin_unlock_irqrestore(&ch->ch_lock, flags); should be +exit_unlock: + spin_unlock_irqrestore(&ch->ch_lock, flags); + if (ld) + tty_ldisc_deref(ld); Should I wait these several weeks to send the second version or should I send a second version fixing this issue a wait for someone to ask me to solve the conflict ? Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Lambert Date: Thu, 12 Mar 2015 09:32:40 +0000 Subject: Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling Message-Id: <55015D38.5060100@gmail.com> List-Id: References: <20150311140433.GA17051@sloth> <55006F4A.70805@gmail.com> <20150312092711.GX10964@mwanda> In-Reply-To: <20150312092711.GX10964@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Dan Carpenter , =?UTF-8?B?R2llZHJpdXMgU3RhdA==?= =?UTF-8?B?a2V2acSNaXVz?= Cc: Lidza Louina , Mark Hounschell , Greg Kroah-Hartman , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org CgpPbiAxMi8wMy8yMDE1IDEwOjI3LCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IE9uIFdlZCwgTWFy IDExLCAyMDE1IGF0IDA2OjM3OjMwUE0gKzAyMDAsIEdpZWRyaXVzIFN0YXRrZXZpxI1pdXMgd3Jv dGU6Cj4+IEl0J3Mgc3RpbGwgbm90IGluIHN0YWdpbmctdGVzdGluZyBmb3Igc29tZSByZWFzb24g OigKPj4KPiBJdCBjYW4gdGFrZSBzZXZlcmFsIHdlZWtzIHRvIGdldCBtZXJnZWQuICBSZWxheC4K Pgo+IHJlZ2FyZHMsCj4gZGFuIGNhcnBlbnRlcgo+CldoYXQgc2hvdWxkIGkgZG8gY29uY2Vybmlu ZyB0aGF0ID8KSSBuZWVkIHRvIHNlbmQgYSBzZWNvbmQgdmVyc2lvbiBvZiB0aGlzIHBhdGNoIGFu eXdheSB0byBmaXggdGhlCmZhY3QgdGhhdCBpIGludmVydGVkIDIgc3RhdGVtZW50cywgbmFtZWx5 OgoKK2V4aXRfdW5sb2NrOgorCWlmIChsZCkKKwkJdHR5X2xkaXNjX2RlcmVmKGxkKTsKKwlzcGlu X3VubG9ja19pcnFyZXN0b3JlKCZjaC0+Y2hfbG9jaywgZmxhZ3MpOwoKc2hvdWxkIGJlCgorZXhp dF91bmxvY2s6CisJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2gtPmNoX2xvY2ssIGZsYWdzKTsK KwlpZiAobGQpCisJCXR0eV9sZGlzY19kZXJlZihsZCk7CgpTaG91bGQgSSB3YWl0IHRoZXNlIHNl dmVyYWwgd2Vla3MgdG8gc2VuZCB0aGUgc2Vjb25kIHZlcnNpb24gb3Igc2hvdWxkCkkgc2VuZCBh IHNlY29uZCB2ZXJzaW9uIGZpeGluZyB0aGlzIGlzc3VlIGEgd2FpdCBmb3Igc29tZW9uZSB0byBh c2sgbWUKdG8gc29sdmUgdGhlIGNvbmZsaWN0ID8KClF1ZW50aW4KLS0KVG8gdW5zdWJzY3JpYmUg ZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGtlcm5lbC1qYW5pdG9y cyIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcK TW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8t aW5mby5odG1s