From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH v3 4/6] drm/i915: reprogram NOA muxes on context switch when using perf Date: Wed, 9 May 2018 10:12:51 +0100 Message-ID: <5501921e-21f7-5072-b3b0-d31e6d26a560@intel.com> References: <20180508180347.32080-1-lionel.g.landwerlin@intel.com> <20180508180347.32080-5-lionel.g.landwerlin@intel.com> <152585634941.3513.5801349713622514922@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1998526878==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 997166ECCD for ; Wed, 9 May 2018 09:12:53 +0000 (UTC) In-Reply-To: <152585634941.3513.5801349713622514922@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1998526878== Content-Type: multipart/alternative; boundary="------------01043C84CE087A381812A95A" Content-Language: en-US This is a multi-part message in MIME format. --------------01043C84CE087A381812A95A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 09/05/18 09:59, Chris Wilson wrote: >> + >> + *cs++ = MI_BATCH_BUFFER_START_GEN8 | MI_BATCH_SECOND_LEVEL; > You are not a second level batch. You are calling from the ring to a > global address of _0_. > >> + *cs++ = 0; > low 32bits = 0 > >> + *cs++ = i915_ggtt_offset(stream->noa_reprogram_vma); > high 32bits = address you wanted. (order reversed) > How is this not hanging my machine is beyond me... :( --------------01043C84CE087A381812A95A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

On 09/05/18 09:59, Chris Wilson wrote:

+
+       *cs++ = MI_BATCH_BUFFER_START_GEN8 | MI_BATCH_SECOND_LEVEL;

You are not a second level batch. You are calling from the ring to a
global address of _0_.

+       *cs++ = 0;

low 32bits = 0

+       *cs++ = i915_ggtt_offset(stream->noa_reprogram_vma);

high 32bits = address you wanted. (order reversed)

How is this not hanging my machine is beyond me... :(

--------------01043C84CE087A381812A95A-- --===============1998526878== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1998526878==--