From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbbCMJzP (ORCPT ); Fri, 13 Mar 2015 05:55:15 -0400 Received: from service87.mimecast.com ([91.220.42.44]:42055 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbbCMJzN convert rfc822-to-8bit (ORCPT ); Fri, 13 Mar 2015 05:55:13 -0400 Message-ID: <5502B3F6.2050603@arm.com> Date: Fri, 13 Mar 2015 09:55:02 +0000 From: Vladimir Murzin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Guenter Roeck , Andrew Morton CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK References: <1426237389-10093-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1426237389-10093-1-git-send-email-linux@roeck-us.net> X-OriginalArrivalTime: 13 Mar 2015 09:55:10.0916 (UTC) FILETIME=[CB6B1840:01D05D73] X-MC-Unique: 115031309551001101 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/15 09:03, Guenter Roeck wrote: > Building alpha:allmodconfig fails with > > mm/memtest.c: In function 'reserve_bad_mem': > mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve' > mm/memtest.c: In function 'do_one_pass': > mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range' > mm/memtest.c:77:73: error: expected ';' before '{' token > > because it depends on MEMBLOCK which is not defined for the alpha > architecture. > > Fixes: 420c89e6185d ("mm: move memtest under mm") > Cc: Vladimir Murzin > Signed-off-by: Guenter Roeck > --- > lib/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 8b4e69a..dc1e69c 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1797,6 +1797,7 @@ config TEST_UDELAY > > config MEMTEST > bool "Memtest" > + depends on MEMBLOCK > ---help--- > This option adds a kernel parameter 'memtest', which allows memtest > to be set. > Thanks for fixing it! Acked-by: Vladimir Murzin Cheers Vladimir