All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel@lists.xenproject.org, julien.grall@linaro.org
Subject: Re: [PATCH v2] xsm: add device tree labeling support
Date: Fri, 13 Mar 2015 09:23:15 +0000	[thread overview]
Message-ID: <5502BA930200007800069A16@mail.emea.novell.com> (raw)
In-Reply-To: <1426192942-6029-1-git-send-email-dgdegra@tycho.nsa.gov>

>>> On 12.03.15 at 21:42, <dgdegra@tycho.nsa.gov> wrote:
> @@ -1999,11 +2055,23 @@ int policydb_read(struct policydb *p, void *fp)
>                          "Old xen policy does not support iomemcon");
>                      goto bad;
>                  }
> -                rc = next_entry(buf, fp, sizeof(u32) *2);
> -                if ( rc < 0 )
> -                    goto bad;
> -                c->u.iomem.low_iomem = le32_to_cpu(buf[0]);
> -                c->u.iomem.high_iomem = le32_to_cpu(buf[1]);
> +                if ( p->policyvers >= POLICYDB_VERSION_XEN_DEVICETREE )
> +                {
> +                    u64 b64[2];
> +                    rc = next_entry(b64, fp, sizeof(u64) *2);
> +                    if ( rc < 0 )
> +                        goto bad;
> +                    c->u.iomem.low_iomem = le64_to_cpu(b64[0]);
> +                    c->u.iomem.high_iomem = le64_to_cpu(b64[1]);
> +                }
> +                else
> +                {
> +                    rc = next_entry(buf, fp, sizeof(u32) *2);
> +                    if ( rc < 0 )
> +                        goto bad;
> +                    c->u.iomem.low_iomem = le32_to_cpu(buf[0]);
> +                    c->u.iomem.high_iomem = le32_to_cpu(buf[1]);
> +                }

I might be completely wrong (knowing next to nothing about XSM),
but how is the permissible I/O mem range tied to DT (as expressed
by POLICYDB_VERSION_XEN_DEVICETREE)? All systems with
valid page frame number possibly being wider than 32 bits would
need this extension, i.e. namely also x86.

Jan

  reply	other threads:[~2015-03-13  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 20:42 [PATCH v2] xsm: add device tree labeling support Daniel De Graaf
2015-03-13  9:23 ` Jan Beulich [this message]
2015-03-13 10:05   ` Julien Grall
2015-03-13 14:39     ` Daniel De Graaf
2015-03-13 15:57 ` Julien Grall
2015-03-17  9:43 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5502BA930200007800069A16@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=julien.grall@linaro.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.