From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/5] ath9k patches
Date: Sat, 14 Mar 2015 05:35:19 +0100 [thread overview]
Message-ID: <5503BA87.7000309@openwrt.org> (raw)
In-Reply-To: <21763.32496.935954.70693@gargle.gargle.HOWL>
On 2015-03-14 01:21, Sujith Manoharan wrote:
> Kalle Valo wrote:
>> With these patches I got a new warning:
>>
>> drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function 'ar9003_aic_cal_post_process':
>> drivers/net/wireless/ath/ath9k/ar9003_aic.c:431:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>>
>> Is it a valid warning?
>
> When CONFIG_FRAME_WARN is set to 1024, this will be hit.
> On my machine, the value is 2048, so the stack doesn't overflow.
>
> But, 1024 could be a valid limit in some architectures, so I'll
> rework ar9003_aic_cal_post_process() to avoid using the stack
> excessively and post another series.
It's probably enough to just change struct ath_aic_sram_info to make it
fit: Just put the bool fields together and make them single-bit.
This should save more than 300 bytes.
- Felix
next prev parent reply other threads:[~2015-03-14 4:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 8:50 [PATCH 0/5] ath9k patches Sujith Manoharan
2015-03-09 8:50 ` [PATCH 1/5] ath9k: Add PCIE powersave macros Sujith Manoharan
2015-03-13 13:20 ` [1/5] " Kalle Valo
2015-03-09 8:50 ` [PATCH 2/5] ath9k: Fix PLL powersave for AR9485 Sujith Manoharan
2015-03-09 8:50 ` [PATCH 3/5] ath9k: Initialize pll_pwrsave for AR9462/AR9565 Sujith Manoharan
2015-03-09 8:50 ` [PATCH 4/5] ath9k: Check allowed PCIE powersave configuration Sujith Manoharan
2015-03-09 8:50 ` [PATCH 5/5] ath9k: Fix RTT chainmask usage Sujith Manoharan
2015-03-13 13:31 ` [PATCH 0/5] ath9k patches Kalle Valo
2015-03-14 0:21 ` Sujith Manoharan
2015-03-14 4:35 ` Felix Fietkau [this message]
2015-03-14 5:56 ` Sujith Manoharan
-- strict thread matches above, loose matches on Subject: below --
2014-12-19 1:03 Sujith Manoharan
2015-01-06 18:01 ` Kalle Valo
2015-01-07 0:46 ` Sujith Manoharan
2015-01-07 7:14 ` Kalle Valo
2015-01-15 12:29 ` Kalle Valo
2014-10-09 8:12 Sujith Manoharan
2014-10-01 3:04 Sujith Manoharan
2014-09-24 6:18 Sujith Manoharan
2014-09-15 5:55 Sujith Manoharan
2014-09-10 13:45 Sujith Manoharan
2014-09-03 7:55 Sujith Manoharan
2014-09-04 17:24 ` John W. Linville
2014-09-05 0:48 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5503BA87.7000309@openwrt.org \
--to=nbd@openwrt.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.