All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pan Bian <bianpan2016@163.com>, Matias Bjorling <mb@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: fix memory leak when submit fails
Date: Thu, 21 Jan 2021 05:47:43 -0700	[thread overview]
Message-ID: <55045608-01cb-d5af-682b-5a213944e33d@kernel.dk> (raw)
In-Reply-To: <20210121072202.120810-1-bianpan2016@163.com>

On 1/21/21 12:22 AM, Pan Bian wrote:
> The allocated page is not released if error occurs in
> nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
> possible memory leak issue.

Applied, thanks.

General question for Matias - is lightnvm maintained anymore at all, or
should we remove it? The project seems dead from my pov, and I don't
even remember anyone even reviewing fixes from other people.

-- 
Jens Axboe


  reply	other threads:[~2021-01-21 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  7:22 [PATCH] lightnvm: fix memory leak when submit fails Pan Bian
2021-01-21 12:47 ` Jens Axboe [this message]
2021-01-21 13:28   ` Javier González
2021-01-21 13:55   ` Matias Bjørling
2021-01-21 16:58     ` Heiner Litz
2021-01-21 18:25       ` Matias Bjørling
2021-01-21 19:49         ` Heiner Litz
2021-01-21 20:14           ` Matias Bjørling
2021-01-21 23:20             ` Heiner Litz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55045608-01cb-d5af-682b-5a213944e33d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bianpan2016@163.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.