From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7EFC433E0 for ; Wed, 3 Feb 2021 17:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B008564F8C for ; Wed, 3 Feb 2021 17:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbhBCRfh (ORCPT ); Wed, 3 Feb 2021 12:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231492AbhBCRfb (ORCPT ); Wed, 3 Feb 2021 12:35:31 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D2DC0613D6; Wed, 3 Feb 2021 09:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=IplVCXo/fDkx+BXjEgdOrbEbvFLMTzBBOaSFZdXnnUo=; b=O+0QFz8WNyP+bUpVa4sYuqhOA+ qCcgnBgu+rf/UQE/qghz9ETIkklfhYRfO6XHR5D6amQ5W33jcZSo8+JtSB+/EdRSZD2GifxI/AdTO RXALNbkSx3r5+OGLtoPQUk8m+ytOtMPdPz5JrMFHnBAjE6mtBblfHkgkUQ8lZy0ywG+Qup0VJYazD JzW5h9zsj5qJw9+hpVqQFsKrI+V5MmOH1OwvThoaR2WdYIJUDHVO884SQbq29NkeUwTN0sgQXVo8y uNMkzJncApz+ueehvrUdhfPDsSJ6U9Jb8wMOOnOvOtp7HXMoKdJ92GgHPnq6hunA739Eg6pEhbtux eSnT5zjA==; Received: from [2601:1c0:6280:3f0::aec2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7M3D-0001ML-P8; Wed, 03 Feb 2021 17:34:48 +0000 Subject: Re: linux-next: build failure after merge of the akpm-current tree To: Arnd Bergmann , Stephen Rothwell Cc: Andrew Morton , Pavel Tatashin , Linux Kernel Mailing List , Linux Next Mailing List References: <20210202200324.5179db33@canb.auug.org.au> From: Randy Dunlap Message-ID: <5504da4f-7eec-ecb0-c47d-7821d06dc880@infradead.org> Date: Wed, 3 Feb 2021 09:34:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/21 9:09 AM, Arnd Bergmann wrote: > On Tue, Feb 2, 2021 at 10:12 AM Stephen Rothwell wrote: > >> >> 983cb10d3f90 ("mm/gup: do not migrate zero page") >> >> I have applied the following patch for today: >> >> From: Stephen Rothwell >> Date: Tue, 2 Feb 2021 19:49:00 +1100 >> Subject: [PATCH] make is_pinnable_page a macro >> >> As it is currently defined before page_to_section() which it needs. >> >> Signed-off-by: Stephen Rothwell > > I still see the same problem in next-20210203, and your patch below > fixes it for me. > Did you drop it from the latest build? > > Arnd After the most recent build errors, I tried to apply Pavel's patch https://lore.kernel.org/linux-mm/CA+CK2bBjC8=cRsL5VhWkcevPsqSXWhsANVjsFNMERLT8vWtiQw@mail.gmail.com/ but patch said that it was already applied (by Andrew I think), so I bailed out (gave up). >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 58f250cabea6..a608feb0d42e 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1128,11 +1128,9 @@ static inline bool is_zone_movable_page(const struct page *page) >> } >> >> /* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */ >> -static inline bool is_pinnable_page(struct page *page) >> -{ >> - return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) || >> - is_zero_pfn(page_to_pfn(page)); >> -} >> +#define is_pinnable_page(page) \ >> + (!(is_zone_movable_page(page) || is_migrate_cma_page(page)) || \ >> + is_zero_pfn(page_to_pfn(page))) >> >> #ifdef CONFIG_DEV_PAGEMAP_OPS >> void free_devmap_managed_page(struct page *page); -- ~Randy