All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Chuck Wolber <chuckwolber@gmail.com>,
	Yocto-mailing-list <yocto@yoctoproject.org>
Subject: Re: [yocto] Recipe Grep'ing
Date: Wed, 5 May 2021 17:50:40 -0700	[thread overview]
Message-ID: <55052749-a440-214d-84b7-4b3e5923ee72@gmail.com> (raw)
In-Reply-To: <CAB=6tBTGiMBH+g-uy3sr1jKA-j1EkSDt0B+8DLb4_iMSaMax6Q@mail.gmail.com>



On 5/5/21 5:41 PM, Chuck Wolber wrote:
> I was pondering putting some work in to a fairly large patch set aimed 
> at making recipes easier to grep through, and wanted to get some 
> feedback before I put time and effort into it.
> 
> I have often found that the following pattern cleanly describes the 
> "what" and the "why" when grep'ing through recipes to search for things:
> 
> FOO += "item1"
> FOO += "item2"
> 
> Whereas this pattern gives us the "what", but not the "why":
> 
> FOO = "item1 \
>               item2 \
>              "
> 
> After discussing this with Richard Purdie on IRC, I also understand that 
> the latter pattern benefits some forms of build output. In addition, for 
> SRC_URI, the "why" is normally fairly obvious from context clues.
> 
> So, is there any interest in accepting a patch set of that nature for 
> Yocto and OE repositories? If so, what variables and situations should 
> be considered "off limits" to a change like that?

I think it is a good idea, however, to make it persistent it would be 
nice to have a linter, which can do such checks and perhaps we can 
enable this in autobuilders so we can keep such cleansups maintained

> 
> ..Ch:W..
> 
> 
> -- 
> *"Perfection must be reached by degrees; she requires the slow hand of 
> time." - Voltaire*
> 
> 
> 
> 

  reply	other threads:[~2021-05-06  0:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  0:41 Recipe Grep'ing Chuck Wolber
2021-05-06  0:50 ` Khem Raj [this message]
2021-05-09  1:25   ` [yocto] " Robert Joslyn
2021-05-12  6:44     ` Chuck Wolber
2021-05-06  2:12 ` Bruce Ashfield
2021-05-06  2:59   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55052749-a440-214d-84b7-4b3e5923ee72@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=chuckwolber@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.