From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXc0k-0002qW-8y for qemu-devel@nongnu.org; Mon, 16 Mar 2015 16:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXc0d-0002aE-Sv for qemu-devel@nongnu.org; Mon, 16 Mar 2015 16:53:18 -0400 Message-ID: <550742B5.5010200@redhat.com> Date: Mon, 16 Mar 2015 16:53:09 -0400 From: Max Reitz MIME-Version: 1.0 References: <1426271419-8277-1-git-send-email-jsnow@redhat.com> <1426271419-8277-7-git-send-email-jsnow@redhat.com> In-Reply-To: <1426271419-8277-7-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [2.4 PATCH v3 06/19] hbitmap: cache array lengths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-03-13 at 14:30, John Snow wrote: > As a convenience: between incremental backups, bitmap migrations > and bitmap persistence we seem to need to recalculate these a lot. > > Because the lengths are a little bit-twiddly, let's just solidly > cache them and be done with it. > > Signed-off-by: John Snow > --- > util/hbitmap.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Max Reitz