From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933670AbbCQKxJ (ORCPT ); Tue, 17 Mar 2015 06:53:09 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:50663 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753706AbbCQKxE (ORCPT ); Tue, 17 Mar 2015 06:53:04 -0400 X-AuditID: cbfec7f4-b7f126d000001e9a-72-550806fdf35f Message-id: <5508078C.6010902@samsung.com> Date: Tue, 17 Mar 2015 11:53:00 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Beata Michalska , kgene@kernel.org Cc: tomasz.figa@gmail.com, mturquette@linaro.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, cw00.choi@samsung.com, kyungmin.park@samsung.com, sw0312.kim@samsung.com Subject: Re: [PATCH 2/2] ARM: dts: exynos3250: Add assigned clock parents to CMU node References: <1425302250-13446-1-git-send-email-b.michalska@samsung.com> <1425302250-13446-3-git-send-email-b.michalska@samsung.com> In-reply-to: <1425302250-13446-3-git-send-email-b.michalska@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xa7p/2ThCDd5/E7CYNqOf3eL6l+es FvOPnGO16H/8mtnibNMbdovLu+awWcw4v4/J4umEi0DW5JdsFqt2/WF04PLYOesuu8emVZ1s Hneu7WHz6NuyitHj8ya5ANYoLpuU1JzMstQifbsErox/e2oKNvNUrLy4gbGBsZ+ri5GTQ0LA ROJPy05mCFtM4sK99WxdjFwcQgJLGSU+dN9nh3A+MUq8XXCZCaSKV0BLouXzPHYQm0VAVeLk 1QNgcTYBQ4neo32MILaoQITEybt72CHqBSV+TL7HAmKLCNhLnHi2E2wDs8BtRolFG/rBGoQF wiX+Td0CtbqVUWLVrh2sIAlOAQ+Jjb9+AE3iAOrQk7h/UQskzCwgL7F5zVvmCYwCs5DsmIVQ NQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYITHwZQfj4mNWhxgFOBiVeHgb8thD hVgTy4orcw8xSnAwK4nwprByhArxpiRWVqUW5ccXleakFh9iZOLglGpgrH8wf3bXnB1nNxrf YnXhkL6/685GxZMFGkYTp3N7zbzZfcVo7RXnJ1+8Plno8i/cd78+dIYJH/t2HabCBmuf8M1G Xi9O1/9xdOrlPDtb9uqC5ws4tZMuzX/+8Y/5wczer0azp16eLLhf4cTq2o88YQWVO7oPVaxJ eLpeoemp3abuxYuvpfc3CCmxFGckGmoxFxUnAgCSLH2NXwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/15 14:17, Beata Michalska wrote: > Use assigned-clocks/assigned-clock-parents properties for > CMU clock controller DT node to secure proper clock setup: > switching the two muxes to root oscillator clock is not only > required for proper powering down the ISP power domain, > but it also reduces the risk of accessing the ISP CMU > registers while the ISP power domain remains turned off > (i.e. through the common clock framework by clk_summary) > > Signed-off-by: Beata Michalska > Acked-by: Kyungmin Park Acked-by: Sylwester Nawrocki Kukjin, please merge this patch for v4.1. I merged the exynos3250 CMU ISP driver patch and we will have regression if $subject patch is not applied, i.e. reading /sys/kernel/debug/clk/clk_summary would cause system hang on exynos3250. > --- > arch/arm/boot/dts/exynos3250.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 277b48b..6d6118e 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -172,6 +172,10 @@ > compatible = "samsung,exynos3250-cmu"; > reg = <0x10030000 0x20000>; > #clock-cells = <1>; > + assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, > + <&cmu CLK_MOUT_ACLK_266_SUB>; > + assigned-clock-parents = <&cmu CLK_FIN_PLL>, > + <&cmu CLK_FIN_PLL>; > }; > > cmu_dmc: clock-controller@105C0000 { > Thanks, Sylwester