From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Date: Tue, 17 Mar 2015 15:18:37 +0000 Subject: Re: [PATCH] ARM: shmobile: cpuidle: Remove the pointless default driver Message-Id: <550845CD.3090704@linaro.org> List-Id: References: <1426602892-17208-1-git-send-email-daniel.lezcano@linaro.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On 03/17/2015 04:06 PM, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Mar 17, 2015 at 3:34 PM, Daniel Lezcano > wrote: >> The default idle driver uses one state with the WFI instruction. >> The default idle routine invokes WFI when no cpuidle driver is present. >> >> The default cpuidle driver is pointless and does not give more than the >> default idle routine and moreover it pulls all the mathematics tied with >> the cpuidle governor for nothing, hence consuming more energy. >> >> Remove the default driver, the related code and register the driver dire= ctly. > > Thanks for your patch! > >> [compiled only - no board - no test] >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/mach-shmobile/common.h | 3 --- >> arch/arm/mach-shmobile/cpuidle.c | 37 ------------------------------= ------- >> arch/arm/mach-shmobile/pm-sh7372.c | 2 +- >> 3 files changed, 1 insertion(+), 41 deletions(-) >> >> diff --git a/arch/arm/mach-shmobile/common.h b/arch/arm/mach-shmobile/co= mmon.h >> index 309025e..29b3088 100644 >> --- a/arch/arm/mach-shmobile/common.h >> +++ b/arch/arm/mach-shmobile/common.h >> @@ -23,8 +23,6 @@ struct clk; >> extern int shmobile_clk_init(void); >> extern void shmobile_handle_irq_intc(struct pt_regs *); >> extern struct platform_suspend_ops shmobile_suspend_ops; >> -struct cpuidle_driver; >> -extern void shmobile_cpuidle_set_driver(struct cpuidle_driver *drv); >> >> #ifdef CONFIG_SUSPEND >> int shmobile_suspend_init(void); >> @@ -51,7 +49,6 @@ extern void __iomem *shmobile_scu_base; >> static inline void __init shmobile_init_late(void) >> { >> shmobile_suspend_init(); >> - shmobile_cpuidle_init(); > > Please remove the forward declaration and dummy for shmobile_cpuidle_init= () > above, too. Ah, yeah. I thought I did it. >> shmobile_cpufreq_init(); >> } >> >> diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobile/c= puidle.c >> index 0afeb5c..e69de29 100644 >> --- a/arch/arm/mach-shmobile/cpuidle.c >> +++ b/arch/arm/mach-shmobile/cpuidle.c >> @@ -1,37 +0,0 @@ > > If you remove this file, you should remove its entry from > arch/arm/mach-shmobile/Makefile, too. > (did you use a config with CONFIG_CPU_IDLE=3Dn?). Yeah, but I have an empty file still around, this is why it was not=20 catched. Thanks for pointing this. >> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile= /pm-sh7372.c >> index c0293ae..9f19052 100644 >> --- a/arch/arm/mach-shmobile/pm-sh7372.c >> +++ b/arch/arm/mach-shmobile/pm-sh7372.c > > Support for sh7372 is scheduled for removal in v4.1, so this will become > a no-op. Cool. So everything will be self contained in this file then. Thanks for the review. -- Daniel --=20 Linaro.org =E2=94=82 Open source software for AR= M SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbbCQPSo (ORCPT ); Tue, 17 Mar 2015 11:18:44 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:34817 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753328AbbCQPSm (ORCPT ); Tue, 17 Mar 2015 11:18:42 -0400 Message-ID: <550845CD.3090704@linaro.org> Date: Tue, 17 Mar 2015 16:18:37 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Simon Horman , Magnus Damm , Linux PM list , "linux-arm-kernel@lists.infradead.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: shmobile: cpuidle: Remove the pointless default driver References: <1426602892-17208-1-git-send-email-daniel.lezcano@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/2015 04:06 PM, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Mar 17, 2015 at 3:34 PM, Daniel Lezcano > wrote: >> The default idle driver uses one state with the WFI instruction. >> The default idle routine invokes WFI when no cpuidle driver is present. >> >> The default cpuidle driver is pointless and does not give more than the >> default idle routine and moreover it pulls all the mathematics tied with >> the cpuidle governor for nothing, hence consuming more energy. >> >> Remove the default driver, the related code and register the driver directly. > > Thanks for your patch! > >> [compiled only - no board - no test] >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/mach-shmobile/common.h | 3 --- >> arch/arm/mach-shmobile/cpuidle.c | 37 ------------------------------------- >> arch/arm/mach-shmobile/pm-sh7372.c | 2 +- >> 3 files changed, 1 insertion(+), 41 deletions(-) >> >> diff --git a/arch/arm/mach-shmobile/common.h b/arch/arm/mach-shmobile/common.h >> index 309025e..29b3088 100644 >> --- a/arch/arm/mach-shmobile/common.h >> +++ b/arch/arm/mach-shmobile/common.h >> @@ -23,8 +23,6 @@ struct clk; >> extern int shmobile_clk_init(void); >> extern void shmobile_handle_irq_intc(struct pt_regs *); >> extern struct platform_suspend_ops shmobile_suspend_ops; >> -struct cpuidle_driver; >> -extern void shmobile_cpuidle_set_driver(struct cpuidle_driver *drv); >> >> #ifdef CONFIG_SUSPEND >> int shmobile_suspend_init(void); >> @@ -51,7 +49,6 @@ extern void __iomem *shmobile_scu_base; >> static inline void __init shmobile_init_late(void) >> { >> shmobile_suspend_init(); >> - shmobile_cpuidle_init(); > > Please remove the forward declaration and dummy for shmobile_cpuidle_init() > above, too. Ah, yeah. I thought I did it. >> shmobile_cpufreq_init(); >> } >> >> diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobile/cpuidle.c >> index 0afeb5c..e69de29 100644 >> --- a/arch/arm/mach-shmobile/cpuidle.c >> +++ b/arch/arm/mach-shmobile/cpuidle.c >> @@ -1,37 +0,0 @@ > > If you remove this file, you should remove its entry from > arch/arm/mach-shmobile/Makefile, too. > (did you use a config with CONFIG_CPU_IDLE=n?). Yeah, but I have an empty file still around, this is why it was not catched. Thanks for pointing this. >> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c >> index c0293ae..9f19052 100644 >> --- a/arch/arm/mach-shmobile/pm-sh7372.c >> +++ b/arch/arm/mach-shmobile/pm-sh7372.c > > Support for sh7372 is scheduled for removal in v4.1, so this will become > a no-op. Cool. So everything will be self contained in this file then. Thanks for the review. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] ARM: shmobile: cpuidle: Remove the pointless default driver Date: Tue, 17 Mar 2015 16:18:37 +0100 Message-ID: <550845CD.3090704@linaro.org> References: <1426602892-17208-1-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Linux PM list , "linux-arm-kernel@lists.infradead.org" , Linux-sh list , "linux-kernel@vger.kernel.org" List-Id: linux-pm@vger.kernel.org On 03/17/2015 04:06 PM, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Mar 17, 2015 at 3:34 PM, Daniel Lezcano > wrote: >> The default idle driver uses one state with the WFI instruction. >> The default idle routine invokes WFI when no cpuidle driver is prese= nt. >> >> The default cpuidle driver is pointless and does not give more than = the >> default idle routine and moreover it pulls all the mathematics tied = with >> the cpuidle governor for nothing, hence consuming more energy. >> >> Remove the default driver, the related code and register the driver = directly. > > Thanks for your patch! > >> [compiled only - no board - no test] >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/mach-shmobile/common.h | 3 --- >> arch/arm/mach-shmobile/cpuidle.c | 37 --------------------------= ----------- >> arch/arm/mach-shmobile/pm-sh7372.c | 2 +- >> 3 files changed, 1 insertion(+), 41 deletions(-) >> >> diff --git a/arch/arm/mach-shmobile/common.h b/arch/arm/mach-shmobil= e/common.h >> index 309025e..29b3088 100644 >> --- a/arch/arm/mach-shmobile/common.h >> +++ b/arch/arm/mach-shmobile/common.h >> @@ -23,8 +23,6 @@ struct clk; >> extern int shmobile_clk_init(void); >> extern void shmobile_handle_irq_intc(struct pt_regs *); >> extern struct platform_suspend_ops shmobile_suspend_ops; >> -struct cpuidle_driver; >> -extern void shmobile_cpuidle_set_driver(struct cpuidle_driver *drv)= ; >> >> #ifdef CONFIG_SUSPEND >> int shmobile_suspend_init(void); >> @@ -51,7 +49,6 @@ extern void __iomem *shmobile_scu_base; >> static inline void __init shmobile_init_late(void) >> { >> shmobile_suspend_init(); >> - shmobile_cpuidle_init(); > > Please remove the forward declaration and dummy for shmobile_cpuidle_= init() > above, too. Ah, yeah. I thought I did it. >> shmobile_cpufreq_init(); >> } >> >> diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobi= le/cpuidle.c >> index 0afeb5c..e69de29 100644 >> --- a/arch/arm/mach-shmobile/cpuidle.c >> +++ b/arch/arm/mach-shmobile/cpuidle.c >> @@ -1,37 +0,0 @@ > > If you remove this file, you should remove its entry from > arch/arm/mach-shmobile/Makefile, too. > (did you use a config with CONFIG_CPU_IDLE=3Dn?). Yeah, but I have an empty file still around, this is why it was not=20 catched. Thanks for pointing this. >> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmo= bile/pm-sh7372.c >> index c0293ae..9f19052 100644 >> --- a/arch/arm/mach-shmobile/pm-sh7372.c >> +++ b/arch/arm/mach-shmobile/pm-sh7372.c > > Support for sh7372 is scheduled for removal in v4.1, so this will bec= ome > a no-op. Cool. So everything will be self contained in this file then. Thanks for the review. -- Daniel --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 17 Mar 2015 16:18:37 +0100 Subject: [PATCH] ARM: shmobile: cpuidle: Remove the pointless default driver In-Reply-To: References: <1426602892-17208-1-git-send-email-daniel.lezcano@linaro.org> Message-ID: <550845CD.3090704@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/17/2015 04:06 PM, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Mar 17, 2015 at 3:34 PM, Daniel Lezcano > wrote: >> The default idle driver uses one state with the WFI instruction. >> The default idle routine invokes WFI when no cpuidle driver is present. >> >> The default cpuidle driver is pointless and does not give more than the >> default idle routine and moreover it pulls all the mathematics tied with >> the cpuidle governor for nothing, hence consuming more energy. >> >> Remove the default driver, the related code and register the driver directly. > > Thanks for your patch! > >> [compiled only - no board - no test] >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/mach-shmobile/common.h | 3 --- >> arch/arm/mach-shmobile/cpuidle.c | 37 ------------------------------------- >> arch/arm/mach-shmobile/pm-sh7372.c | 2 +- >> 3 files changed, 1 insertion(+), 41 deletions(-) >> >> diff --git a/arch/arm/mach-shmobile/common.h b/arch/arm/mach-shmobile/common.h >> index 309025e..29b3088 100644 >> --- a/arch/arm/mach-shmobile/common.h >> +++ b/arch/arm/mach-shmobile/common.h >> @@ -23,8 +23,6 @@ struct clk; >> extern int shmobile_clk_init(void); >> extern void shmobile_handle_irq_intc(struct pt_regs *); >> extern struct platform_suspend_ops shmobile_suspend_ops; >> -struct cpuidle_driver; >> -extern void shmobile_cpuidle_set_driver(struct cpuidle_driver *drv); >> >> #ifdef CONFIG_SUSPEND >> int shmobile_suspend_init(void); >> @@ -51,7 +49,6 @@ extern void __iomem *shmobile_scu_base; >> static inline void __init shmobile_init_late(void) >> { >> shmobile_suspend_init(); >> - shmobile_cpuidle_init(); > > Please remove the forward declaration and dummy for shmobile_cpuidle_init() > above, too. Ah, yeah. I thought I did it. >> shmobile_cpufreq_init(); >> } >> >> diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobile/cpuidle.c >> index 0afeb5c..e69de29 100644 >> --- a/arch/arm/mach-shmobile/cpuidle.c >> +++ b/arch/arm/mach-shmobile/cpuidle.c >> @@ -1,37 +0,0 @@ > > If you remove this file, you should remove its entry from > arch/arm/mach-shmobile/Makefile, too. > (did you use a config with CONFIG_CPU_IDLE=n?). Yeah, but I have an empty file still around, this is why it was not catched. Thanks for pointing this. >> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c >> index c0293ae..9f19052 100644 >> --- a/arch/arm/mach-shmobile/pm-sh7372.c >> +++ b/arch/arm/mach-shmobile/pm-sh7372.c > > Support for sh7372 is scheduled for removal in v4.1, so this will become > a no-op. Cool. So everything will be self contained in this file then. Thanks for the review. -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog