From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXw52-000562-9Z for qemu-devel@nongnu.org; Tue, 17 Mar 2015 14:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXw4x-0000RX-Bd for qemu-devel@nongnu.org; Tue, 17 Mar 2015 14:19:04 -0400 Message-ID: <5508700F.3070104@redhat.com> Date: Tue, 17 Mar 2015 12:18:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1425528911-10300-1-git-send-email-jsnow@redhat.com> <1425528911-10300-4-git-send-email-jsnow@redhat.com> <550868A1.9090508@redhat.com> <55086CC8.1020102@redhat.com> In-Reply-To: <55086CC8.1020102@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9SNKcLrDW1klUbjJSL5HmPjFtukbV2xkk" Subject: Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Max Reitz , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9SNKcLrDW1klUbjJSL5HmPjFtukbV2xkk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2015 12:04 PM, John Snow wrote: >>> +typedef void (CallbackFn)(void *opaque, int ret); >>> + >>> +/* Temporary. Removed in the next patch. */ >> >> Actually, no. :-) >> >> (remove in patch 7) >> >> Why are you making them non-static in the first place? I see both >> functions mentioned in patch 3 and patch 7 only (except for context in= >> patch 6). >> >=20 > Won't compile otherwise, because they have no users as of this patch. I= > am trying to keep the size of these patches down and in a sane order. Another solution is to mark it static, but also add __attribute__((unused)) to shut the compiler up, so that you don't cause build failures, but also don't cause reviewers to wonder who is using it. Then when it finally gets used, a patch to remove the attribute is easier to see than a patch adding static. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9SNKcLrDW1klUbjJSL5HmPjFtukbV2xkk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCHAPAAoJEKeha0olJ0NqzoIH/38vOw3XYc9CpxHowFUFT415 5pa5ZOL0eKH0zpxmZRmmN+GyjaUyPGjvjag3mi/Hgc8qwN6jPumAwibJXqrngax9 JRWxBb4z62UrqJzvB66TOL44glGodrtUFbaVzScwl63iAWNjeKjfmoI56nHEEzgr 0DxMhBQadMzuqrZm+ubnyn3zJ2QEsqO2+6+Xl9WpSU565MS+pLj/ChblCNit2AUG +xJer6Pw5wG6HNvYU9e/s2a2J80kThdctZEUKAMI9ujFyLbJ7HpnyIA4HOjHwbHE S3WapmVMGqMY6cilqppSyvMBDi1im+scAhs5UOiMWj72/1cTPjbxgS/xsk2ORKA= =jmBx -----END PGP SIGNATURE----- --9SNKcLrDW1klUbjJSL5HmPjFtukbV2xkk--