From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXxuA-000129-5Z for qemu-devel@nongnu.org; Tue, 17 Mar 2015 16:15:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXxu6-00007p-2t for qemu-devel@nongnu.org; Tue, 17 Mar 2015 16:15:58 -0400 Message-ID: <55088B77.7080803@redhat.com> Date: Tue, 17 Mar 2015 14:15:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1425528911-10300-1-git-send-email-jsnow@redhat.com> <1425528911-10300-7-git-send-email-jsnow@redhat.com> <550877CE.5080501@redhat.com> <55087D91.1040809@redhat.com> In-Reply-To: <55087D91.1040809@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rWihqiTEtSaovaqxq6lgU0FggbPsfKD8g" Subject: Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Max Reitz , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rWihqiTEtSaovaqxq6lgU0FggbPsfKD8g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2015 01:16 PM, John Snow wrote: >> Other than that, I'm okay with a forward-declaration; if you want to >> move it, but I'd be fine with moving the code, too. >> >> With _drive_backup() being called do_drive_backup(): >> >> Reviewed-by: Max Reitz >> >=20 > Moving the code around might be better, it just makes for a much noisie= r > patch. I made my decisions for v1 to keep code disturbed the least. >=20 > Once more critiques roll in I will decide what to do. I like avoiding forward declarations for non-recursive static functions (aka topological sorting); but if you do code motion, do it in a separate patch from the other changes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rWihqiTEtSaovaqxq6lgU0FggbPsfKD8g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCIt3AAoJEKeha0olJ0Nq6j8H/jSe+5tA/GGIb8Rb1FMLCd5r Rna+Hg5sh6BQh9mT95gv3VotL80DabrK+VFrznGmWriFEqLDIeSKisqDN1JzWT22 uByRg+nl5Uhvy+HqXnIc3MX0NaCwC83PpOA/Vb+HpT3+mY9yrJb1BWA4A0DFes+P RmVCLBg0uo7E3XCKYh8CStJHJz63pcFqQvSKES2AMF5Ep1dTcETj0vAI+59SJl00 o7VEIBkEY+8Umht6QisJdZE5i9h3uoHpvC+92H0J1mRyQ1G5XDaTNflE367M3AQR +NfH1cD4PPqXDoWdmy3scfXG8pdFTEDMxpbzqpRy/PTf7pa0GHLcg4w6+deuYn8= =ln88 -----END PGP SIGNATURE----- --rWihqiTEtSaovaqxq6lgU0FggbPsfKD8g--