From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934182AbbCROWu (ORCPT ); Wed, 18 Mar 2015 10:22:50 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:35767 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933913AbbCROWo (ORCPT ); Wed, 18 Mar 2015 10:22:44 -0400 Message-ID: <55098A2C.50905@cogentembedded.com> Date: Wed, 18 Mar 2015 17:22:36 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Harish Jenny K N , marcel@holtmann.org CC: gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix use after free in l2cap_chan_timeout References: <1426679940-20710-1-git-send-email-harish_kandiga@mentor.com> In-Reply-To: <1426679940-20710-1-git-send-email-harish_kandiga@mentor.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 3/18/2015 2:59 PM, Harish Jenny K N wrote: > There is a potential use after free in bt_sock_poll when a > socket gets killed without getting unlinked from accept_q. > Hence added code to unlink from accpept_q by calling teardown > before freeing the socket for channel type L2CAP_CHAN_CONN_ORIENTED. > Signed-off-by: Harish Jenny K N > --- > net/bluetooth/l2cap_core.c | 5 +++++ > 1 file changed, 5 insertions(+) > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 6ba33f9..3c3421e 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -415,6 +415,11 @@ static void l2cap_chan_timeout(struct work_struct *work) > > l2cap_chan_close(chan, reason); > > + if (((chan->state == BT_CONNECTED) || (chan->state == BT_CONFIG)) && Note that parens around == are unnecessary. > + chan->chan_type == L2CAP_CHAN_CONN_ORIENTED) { > + chan->ops->teardown(chan, 0); > + } > + [...] WBR, Sergei