From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YYu2j-00076N-KJ
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YYu2g-0004le-ET
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:41 -0400
Received: from mga11.intel.com ([192.55.52.93]:53808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YYu2g-0004lY-6B
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:38 -0400
Message-ID: <550BF473.2050708@intel.com>
Date: Fri, 20 Mar 2015 18:20:35 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1425980538-5508-1-git-send-email-tiejun.chen@intel.com>									
	<1425980538-5508-3-git-send-email-tiejun.chen@intel.com>								
	<1426073641.21353.192.camel@citrix.com>
	<55010596.2030106@intel.com>							
	<1426163186.21353.409.camel@citrix.com>
	<55023FDA.7030204@intel.com>						
	<1426241479.32572.94.camel@citrix.com>
	<55062CD2.8050305@intel.com>					
	<1426508400.18247.33.camel@citrix.com>
	<5507DBD6.8030401@intel.com>				
	<1426584396.18247.136.camel@citrix.com>
	<55092A24.8010409@intel.com>			
	<1426674310.18247.318.camel@citrix.com>
	<550A2F6A.4060508@intel.com>		 <1426761860.610.22.camel@citrix.com>
	<550B7207.6020503@intel.com>	
	<1426844430.21742.101.camel@citrix.com> <550BF188.20401@intel.com>
	<1426846305.21742.116.camel@citrix.com>
In-Reply-To: <1426846305.21742.116.camel@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@citrix.com, xen-devel@lists.xen.org

On 2015/3/20 18:11, Ian Campbell wrote:
> On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote:
>> +        if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) {
>> +            if (libxl_gfx_passthru_kind_from_string(buf,
>> +
>> &b_info->u.hvm.gfx_passthru_kind)) {
>> +                fprintf(stderr,
>> +                        "ERROR: invalid value \"%s\" for
>> \"gfx_passthru_kind\"\n",
>> +                        buf);
>> +                exit (1);
>> +            }
>> +        }
>
> This unnecessary bit seems to have crept back in.

Sorry to hit this again when I address other comments.

>
> Don't forget to update the manpages if you haven't already.
>

Looks I need to update docs/man/xl.cfg.pod.5.

Thanks
Tiejun