From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbbCTKjl (ORCPT ); Fri, 20 Mar 2015 06:39:41 -0400 Received: from service87.mimecast.com ([91.220.42.44]:41973 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbCTKjj convert rfc822-to-8bit (ORCPT ); Fri, 20 Mar 2015 06:39:39 -0400 Message-ID: <550BF8E2.9020002@arm.com> Date: Fri, 20 Mar 2015 10:39:30 +0000 From: Vladimir Murzin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Paul Bolle , Guenter Roeck CC: "valentinrothberg@gmail.com" , "rupran@einserver.de" , "stefan.hengelein@fau.de" , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK References: <1426237389-10093-1-git-send-email-linux@roeck-us.net> <1426847014.23529.35.camel@x220> In-Reply-To: <1426847014.23529.35.camel@x220> X-OriginalArrivalTime: 20 Mar 2015 10:39:36.0443 (UTC) FILETIME=[29167CB0:01D062FA] X-MC-Unique: 115032010393702801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/03/15 10:23, Paul Bolle wrote: > On Fri, 2015-03-13 at 02:03 -0700, Guenter Roeck wrote: >> Building alpha:allmodconfig fails with >> >> mm/memtest.c: In function 'reserve_bad_mem': >> mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve' >> mm/memtest.c: In function 'do_one_pass': >> mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range' >> mm/memtest.c:77:73: error: expected ';' before '{' token >> >> because it depends on MEMBLOCK which is not defined for the alpha >> architecture. >> >> Fixes: 420c89e6185d ("mm: move memtest under mm") >> Cc: Vladimir Murzin >> Signed-off-by: Guenter Roeck >> --- >> lib/Kconfig.debug | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 8b4e69a..dc1e69c 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1797,6 +1797,7 @@ config TEST_UDELAY >> >> config MEMTEST >> bool "Memtest" >> + depends on MEMBLOCK >> ---help--- >> This option adds a kernel parameter 'memtest', which allows memtest >> to be set. > > (There's now a bot checking this stuff, but I couldn't resist reporting > it when my script spotted it.) > > Please do > $ git grep -n "config\s\+MEMBLOCK\b" next-20150320 > $ git grep -n "config\s\+MEMBLOCK\b" v4.0-rc4 > > I think this patch simply disables MEMTEST altogether. I'm guessing this I should have tested it before... yes, you (and bot) are right, after patch applied memtest is not available at arm/arm64 which definitely has memblock. > should have added > depends on HAVE_MEMBLOCK > Could we fold this change or separate patch is needed? Cheers Vladimir > > Paul Bolle > >