From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbbCUWlL (ORCPT ); Sat, 21 Mar 2015 18:41:11 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:57818 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbbCUWlH (ORCPT ); Sat, 21 Mar 2015 18:41:07 -0400 Message-ID: <550DF37E.2090906@roeck-us.net> Date: Sat, 21 Mar 2015 15:41:02 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: netdev@vger.kernel.org CC: "David S. Miller" , Andrew Lunn , Florian Fainelli , linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/18] net: dsa: mv88e6xxx: Provide function for common port initialization References: <1426952815-4642-1-git-send-email-linux@roeck-us.net> <1426952815-4642-3-git-send-email-linux@roeck-us.net> In-Reply-To: <1426952815-4642-3-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.550DF382.0091,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/2015 08:46 AM, Guenter Roeck wrote: > Provide mv88e6xxx_setup_port_common() for common port initialization. > Currently only write Port 1 Control and VLAN configuration since > this will be needed for hardware bridging. More can be added later > if desired/needed. > > Signed-off-by: Guenter Roeck > --- > drivers/net/dsa/mv88e6xxx.c | 39 +++++++++++++++++++++++++++++++++++++++ > drivers/net/dsa/mv88e6xxx.h | 1 + > 2 files changed, 40 insertions(+) > > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > index 6496beb..3c2cb45 100644 > --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -700,6 +700,45 @@ int mv88e6xxx_set_eee(struct dsa_switch *ds, int port, > return 0; > } > > +int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port) > +{ > + struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + int reg; > + > + mutex_lock(&ps->smi_mutex); > + > + /* Port Control 1: disable trunking. Also, if this is the > + * CPU port, enable learn messages to be sent to this port. > + */ > + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x05, > + dsa_is_cpu_port(ds, port) ? 0x8000 : 0x0000); This fails to compile. It is fixed in a later commit which is why I didn't see it. Too much reordering, I guess. Sorry for that. Just a heads up; I'll wait for comments before resubmitting. Guenter