All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varka Bhadram <varkabhadram@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan@vger.kernel.org, Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH bluetooth-next 2/3] cc2520: add set transmit power support
Date: Mon, 23 Mar 2015 09:04:23 +0530	[thread overview]
Message-ID: <550F89BF.8050405@gmail.com> (raw)
In-Reply-To: <20150320153019.GB3952@omega>

On 03/20/2015 09:00 PM, Alexander Aring wrote:
> Hi,
>
> On Fri, Mar 20, 2015 at 12:52:19PM +0530, Varka Bhadram wrote:
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>>   drivers/net/ieee802154/cc2520.c |   56 ++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 55 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
>> index f833b8b..f96cc50 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>> @@ -53,6 +53,17 @@
>>   #define	CC2520_MAXCHANNEL		26
>>   #define	CC2520_CHANNEL_SPACING		5
>>   
>> +/* Tx power values */
>> +#define CC2520_TXPOWER_0		0x03 /* -18dbm */
>> +#define CC2520_TXPOWER_1		0x2c /* -7dbm */
>> +#define CC2520_TXPOWER_2		0x88 /* -4dbm */
>> +#define CC2520_TXPOWER_3		0x81 /* -2dbm */
>> +#define CC2520_TXPOWER_4		0x32 /* 0dbm */
>> +#define CC2520_TXPOWER_5		0x13 /* 1dbm */
>> +#define CC2520_TXPOWER_6		0xab /* 2dbm */
>> +#define CC2520_TXPOWER_7		0xf2 /* 3dbm */
>> +#define CC2520_TXPOWER_8		0xf7 /* 5dbm */
>> +
>>   /* command strobes */
>>   #define	CC2520_CMD_SNOP			0x00
>>   #define	CC2520_CMD_IBUFLD		0x02
>> @@ -628,6 +639,48 @@ cc2520_filter(struct ieee802154_hw *hw,
>>   	return 0;
>>   }
>>   
>> +static int
>> +cc2520_set_txpower(struct ieee802154_hw *hw, int db)
>> +{
> our netlink attribute is s8, maybe we should fix the mac layer at first
> and change the int to s8.

Ok. I will look into that.

> - Alex


-- 
Varka Bhadram


  reply	other threads:[~2015-03-23  3:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20  7:22 [PATCH bluetooth-next 1/3] ieee802154: add set transmit power support Varka Bhadram
2015-03-20  7:22 ` [PATCH bluetooth-next 2/3] cc2520: " Varka Bhadram
2015-03-20  9:19   ` Stefan Schmidt
2015-03-20 16:03     ` Alexander Aring
2015-03-20 15:30   ` Alexander Aring
2015-03-23  3:34     ` Varka Bhadram [this message]
2015-03-20  7:22 ` [PATCH bluetooth-next 3/3] cc2520: fix in updated register settings Varka Bhadram
2015-03-20 15:38   ` Alexander Aring
2015-03-20 15:28 ` [PATCH bluetooth-next 1/3] ieee802154: add set transmit power support Alexander Aring
2015-03-23  3:33   ` Varka Bhadram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550F89BF.8050405@gmail.com \
    --to=varkabhadram@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=varkab@cdac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.