From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v3 3/4] drm/msm/mdp5: Add START signal to kick off certain pipelines Date: Mon, 23 Mar 2015 16:20:46 +0530 Message-ID: <550FF006.6090600@codeaurora.org> References: <1426276174-17010-1-git-send-email-sviau@codeaurora.org> <1426276174-17010-4-git-send-email-sviau@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1426276174-17010-4-git-send-email-sviau@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stephane Viau , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org SGkgU3RlcGhhbmUsCgpPbiAwMy8xNC8yMDE1IDAxOjE5IEFNLCBTdGVwaGFuZSBWaWF1IHdyb3Rl Ogo+IFNvbWUgaW50ZXJmYWNlcyAoV0IsIERTSSBDb21tYW5kIE1vZGUpIG5lZWQgdG8gYmUga2lj a2VkIG9mZgo+IHRocm91Z2ggYSBTVEFSVCBTaWduYWwuIFRoaXMgc2lnbmFsIG5lZWRzIHRvIGJl IHNlbnQgYXQgdGhlIHJpZ2h0Cj4gdGltZSBhbmQgcmVxdWVzdHMgaW4gc29tZSBjYXNlcyB0byBr ZWVwIHRyYWNrIG9mIHRoZSBwaXBlbGluZQo+IHN0YXR1cyAoZWc6IHdoZXRoZXIgcGlwZWxpbmUg cmVnaXN0ZXJzIGFyZSBmbHVzaGVkIEFORCBvdXRwdXQgV0IKPiBidWZmZXJzIGFyZSByZWFkeSwg aW4gY2FzZSBvZiBXQiBpbnRlcmZhY2UpLgo+Cj4gU2lnbmVkLW9mZi1ieTogU3RlcGhhbmUgVmlh dSA8c3ZpYXVAY29kZWF1cm9yYS5vcmc+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL21k cC9tZHA1L21kcDVfY2ZnLmMgICAgIHwgICAyICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRw L21kcDUvbWRwNV9jZmcuaCAgICAgfCAgIDcgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRw L21kcDUvbWRwNV9jcnRjLmMgICAgfCAgMzEgKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL21zbS9t ZHAvbWRwNS9tZHA1X2N0bC5jICAgICB8IDI0NyArKysrKysrKysrKysrKysrKysrKysrKystLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfY3RsLmggICAgIHwgIDcyICsr Ky0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfZW5jb2Rlci5jIHwg IDEzICstCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfa21zLmggICAgIHwg ICAxICsKPiAgIDcgZmlsZXMgY2hhbmdlZCwgMjc2IGluc2VydGlvbnMoKyksIDk3IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9j ZmcuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9jZmcuYwo+IGluZGV4IGMw NzhmMzAuLjcyYzA3NWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRw NS9tZHA1X2NmZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X2Nm Zy5jCj4gQEAgLTMxLDYgKzMxLDcgQEAgY29uc3Qgc3RydWN0IG1kcDVfY2ZnX2h3IG1zbTh4NzRf Y29uZmlnID0gewo+ICAgCS5jdGwgPSB7Cj4gICAJCS5jb3VudCA9IDUsCj4gICAJCS5iYXNlID0g eyAweDAwNjAwLCAweDAwNzAwLCAweDAwODAwLCAweDAwOTAwLCAweDAwYTAwIH0sCj4gKwkJLmZs dXNoX2h3X21hc2sgPSAweDAwMDNmZmZmLAo+ICAgCX0sCj4gICAJLnBpcGVfdmlnID0gewo+ICAg CQkuY291bnQgPSAzLAo+IEBAIC03OCw2ICs3OSw3IEBAIGNvbnN0IHN0cnVjdCBtZHA1X2NmZ19o dyBhcHE4MDg0X2NvbmZpZyA9IHsKPiAgIAkuY3RsID0gewo+ICAgCQkuY291bnQgPSA1LAo+ICAg CQkuYmFzZSA9IHsgMHgwMDYwMCwgMHgwMDcwMCwgMHgwMDgwMCwgMHgwMDkwMCwgMHgwMGEwMCB9 LAo+ICsJCS5mbHVzaF9od19tYXNrID0gMHgwMDNmZmZmZiwKCm1zbTh4MTYgd291bGQgcmVxdWly ZSBhIGZsdXNoX2h3X21hc2sgdG9vLCBpdCBzaG91bGQgYmUgMHgzMmE1OSBpZiBJJ20gCm5vdCB3 cm9uZy4gQ291bGQgeW91IHBsZWFzZSBhZGQgaXQgZm9yIHRoZSBuZXh0IHJldmlzaW9uLCBvciBh cyBhIHBhcnQgCm9mIHRoZSA4eDE2IGh3IGNmZyBwYXRjaD8KClRoYW5rcywKQXJjaGl0CgotLSAK UXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJv cmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbbCWKu4 (ORCPT ); Mon, 23 Mar 2015 06:50:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47731 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbCWKuy (ORCPT ); Mon, 23 Mar 2015 06:50:54 -0400 Message-ID: <550FF006.6090600@codeaurora.org> Date: Mon, 23 Mar 2015 16:20:46 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stephane Viau , dri-devel@lists.freedesktop.org CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com Subject: Re: [PATCH v3 3/4] drm/msm/mdp5: Add START signal to kick off certain pipelines References: <1426276174-17010-1-git-send-email-sviau@codeaurora.org> <1426276174-17010-4-git-send-email-sviau@codeaurora.org> In-Reply-To: <1426276174-17010-4-git-send-email-sviau@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephane, On 03/14/2015 01:19 AM, Stephane Viau wrote: > Some interfaces (WB, DSI Command Mode) need to be kicked off > through a START Signal. This signal needs to be sent at the right > time and requests in some cases to keep track of the pipeline > status (eg: whether pipeline registers are flushed AND output WB > buffers are ready, in case of WB interface). > > Signed-off-by: Stephane Viau > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 2 + > drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 7 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 31 ++-- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 247 ++++++++++++++++++++++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 72 +++----- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 13 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 1 + > 7 files changed, 276 insertions(+), 97 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c > index c078f30..72c075a 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c > @@ -31,6 +31,7 @@ const struct mdp5_cfg_hw msm8x74_config = { > .ctl = { > .count = 5, > .base = { 0x00600, 0x00700, 0x00800, 0x00900, 0x00a00 }, > + .flush_hw_mask = 0x0003ffff, > }, > .pipe_vig = { > .count = 3, > @@ -78,6 +79,7 @@ const struct mdp5_cfg_hw apq8084_config = { > .ctl = { > .count = 5, > .base = { 0x00600, 0x00700, 0x00800, 0x00900, 0x00a00 }, > + .flush_hw_mask = 0x003fffff, msm8x16 would require a flush_hw_mask too, it should be 0x32a59 if I'm not wrong. Could you please add it for the next revision, or as a part of the 8x16 hw cfg patch? Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project