From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d48HR-0002IT-Pu for qemu-devel@nongnu.org; Fri, 28 Apr 2017 11:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d48HN-0004ss-9b for qemu-devel@nongnu.org; Fri, 28 Apr 2017 11:58:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33284) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d48HN-0004sj-0f for qemu-devel@nongnu.org; Fri, 28 Apr 2017 11:57:57 -0400 References: <20170428021317.24711-1-eblake@redhat.com> <20170428021317.24711-3-eblake@redhat.com> <20170428080821.GB2085@work-vm> <3a8d9f68-f30c-1191-ca80-a93f0050f011@redhat.com> <20170428152729.GI2085@work-vm> From: Eric Blake Message-ID: <550a4e37-c4b3-181d-876c-64d73e96e78c@redhat.com> Date: Fri, 28 Apr 2017 10:57:52 -0500 MIME-Version: 1.0 In-Reply-To: <20170428152729.GI2085@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t" Subject: Re: [Qemu-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com, alistair.francis@xilinx.com, Stefano Stabellini , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , zhanghailiang , Juan Quintela , "open list:X86" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t From: Eric Blake To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com, alistair.francis@xilinx.com, Stefano Stabellini , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , zhanghailiang , Juan Quintela , "open list:X86" Message-ID: <550a4e37-c4b3-181d-876c-64d73e96e78c@redhat.com> Subject: Re: [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request References: <20170428021317.24711-1-eblake@redhat.com> <20170428021317.24711-3-eblake@redhat.com> <20170428080821.GB2085@work-vm> <3a8d9f68-f30c-1191-ca80-a93f0050f011@redhat.com> <20170428152729.GI2085@work-vm> In-Reply-To: <20170428152729.GI2085@work-vm> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2017 10:27 AM, Dr. David Alan Gilbert wrote: >>>> +# Enumeration of various causes for shutdown. >>>> +# >>>> +# @host-qmp: Reaction to a QMP command, such as 'quit' >>>> +# @host-signal: Reaction to a signal, such as SIGINT >>>> +# @host-ui: Reaction to a UI event, such as closing the window >>>> +# @host-replay: The host is replaying an earlier shutdown event >>>> +# @host-error: Qemu encountered an error that prevents further use = of the guest >>>> +# @guest-shutdown: The guest requested a shutdown, such as via ACPI= or >>>> +# other hardware-specific action >>>> +# @guest-reset: The guest requested a reset, and the command line >>>> +# response to a reset is to instead trigger a shutdow= n >>>> +# @guest-panic: The guest panicked, and the command line response t= o >>>> +# a panic is to trigger a shutdown >>> > At a higher level, using your tags, I'm not sure where a reset triggere= d > by a fault detected by the hypervisor lives - e.g. an x86 triple fault > where the guest screws up so badly that it just gets reset. Is > that a guest-reset or a guest-panic or what - neither case > was actually asked for by the guest itself. Wouldn't that be host-error (qemu detected an error that prevents further execution of the guest without a reset - and a triple fault seems to fall into the category of the guest getting itself wedged rather than actually trying to reset)? Except patch 3 only used SHUTDOWN_TYPE_HOST_ERROR in the xen portion of the patch. So if any x86 expert has an opinion on where triple-fault handling is emulated, and what category should be used there, I'm welcome to tweaking this series. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZA2aAAAoJEKeha0olJ0Nq/uQH/i8cBEqzsb4+dNLvKx8xxVaQ X1H7kL3mY5sN80wBjzFiGk0bjOU2rMxb8i0QA3MnF/4Cyu6ZfdW7oMuOW1BLYiDH OorlxFPY6nIdN9gF0hFHWzkPbZumKzbn5Itlh44WOzqmMSj/CtKBGoqlq4dzczth zN1hrciq+E/dNtbrshqdYtEl/1O5oUTB770Uc/mUqEKu/IazJ0NqIu6V2QvedlEq 5Mtd1qMiM2/poHGoy15SiGwOcEf+dk6DThPsw1/6HraJ0DqTy+9/+fHR+3kDZXja ST0bHKrGs9wMdOgISfxXoeCbfEbwPjYCdokQOpPVlL+9wSpYSltnnm63Xrzkm+s= =V6t7 -----END PGP SIGNATURE----- --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request Date: Fri, 28 Apr 2017 10:57:52 -0500 Message-ID: <550a4e37-c4b3-181d-876c-64d73e96e78c@redhat.com> References: <20170428021317.24711-1-eblake@redhat.com> <20170428021317.24711-3-eblake@redhat.com> <20170428080821.GB2085@work-vm> <3a8d9f68-f30c-1191-ca80-a93f0050f011@redhat.com> <20170428152729.GI2085@work-vm> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9164863778134761272==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d48HT-0007Pk-CE for xen-devel@lists.xenproject.org; Fri, 28 Apr 2017 15:58:03 +0000 In-Reply-To: <20170428152729.GI2085@work-vm> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "Dr. David Alan Gilbert" Cc: Stefano Stabellini , berrange@redhat.com, Eduardo Habkost , "Michael S. Tsirkin" , armbru@redhat.com, Juan Quintela , qemu-devel@nongnu.org, alistair.francis@xilinx.com, zhanghailiang , "open list:X86" , Anthony Perard , Paolo Bonzini , Richard Henderson List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9164863778134761272== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t Content-Type: multipart/mixed; boundary="mVdNmKVue7IesFbM8xhNKmJd7GI6GokEm"; protected-headers="v1" From: Eric Blake To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com, alistair.francis@xilinx.com, Stefano Stabellini , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , zhanghailiang , Juan Quintela , "open list:X86" Message-ID: <550a4e37-c4b3-181d-876c-64d73e96e78c@redhat.com> Subject: Re: [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request References: <20170428021317.24711-1-eblake@redhat.com> <20170428021317.24711-3-eblake@redhat.com> <20170428080821.GB2085@work-vm> <3a8d9f68-f30c-1191-ca80-a93f0050f011@redhat.com> <20170428152729.GI2085@work-vm> In-Reply-To: <20170428152729.GI2085@work-vm> --mVdNmKVue7IesFbM8xhNKmJd7GI6GokEm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/28/2017 10:27 AM, Dr. David Alan Gilbert wrote: >>>> +# Enumeration of various causes for shutdown. >>>> +# >>>> +# @host-qmp: Reaction to a QMP command, such as 'quit' >>>> +# @host-signal: Reaction to a signal, such as SIGINT >>>> +# @host-ui: Reaction to a UI event, such as closing the window >>>> +# @host-replay: The host is replaying an earlier shutdown event >>>> +# @host-error: Qemu encountered an error that prevents further use = of the guest >>>> +# @guest-shutdown: The guest requested a shutdown, such as via ACPI= or >>>> +# other hardware-specific action >>>> +# @guest-reset: The guest requested a reset, and the command line >>>> +# response to a reset is to instead trigger a shutdow= n >>>> +# @guest-panic: The guest panicked, and the command line response t= o >>>> +# a panic is to trigger a shutdown >>> > At a higher level, using your tags, I'm not sure where a reset triggere= d > by a fault detected by the hypervisor lives - e.g. an x86 triple fault > where the guest screws up so badly that it just gets reset. Is > that a guest-reset or a guest-panic or what - neither case > was actually asked for by the guest itself. Wouldn't that be host-error (qemu detected an error that prevents further execution of the guest without a reset - and a triple fault seems to fall into the category of the guest getting itself wedged rather than actually trying to reset)? Except patch 3 only used SHUTDOWN_TYPE_HOST_ERROR in the xen portion of the patch. So if any x86 expert has an opinion on where triple-fault handling is emulated, and what category should be used there, I'm welcome to tweaking this series. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --mVdNmKVue7IesFbM8xhNKmJd7GI6GokEm-- --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZA2aAAAoJEKeha0olJ0Nq/uQH/i8cBEqzsb4+dNLvKx8xxVaQ X1H7kL3mY5sN80wBjzFiGk0bjOU2rMxb8i0QA3MnF/4Cyu6ZfdW7oMuOW1BLYiDH OorlxFPY6nIdN9gF0hFHWzkPbZumKzbn5Itlh44WOzqmMSj/CtKBGoqlq4dzczth zN1hrciq+E/dNtbrshqdYtEl/1O5oUTB770Uc/mUqEKu/IazJ0NqIu6V2QvedlEq 5Mtd1qMiM2/poHGoy15SiGwOcEf+dk6DThPsw1/6HraJ0DqTy+9/+fHR+3kDZXja ST0bHKrGs9wMdOgISfxXoeCbfEbwPjYCdokQOpPVlL+9wSpYSltnnm63Xrzkm+s= =V6t7 -----END PGP SIGNATURE----- --wmvwLKOR7Vrce4GsrUoopHEwxOcujeQ4t-- --===============9164863778134761272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============9164863778134761272==--