All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	~okias/devicetree@lists.sr.ht, Andy Gross <andy.gross@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: convert Qualcomm SCM binding to the yaml
Date: Sun, 10 Apr 2022 10:50:52 +0200	[thread overview]
Message-ID: <550e04f5-acd9-e50a-1aae-4e639951e35e@linaro.org> (raw)
In-Reply-To: <YfhT/ltPDhQZV0Bo@builder.lan>

On 31/01/2022 22:26, Bjorn Andersson wrote:
> On Sat 18 Dec 13:40 CST 2021, David Heidelberg wrote:
> 
>> Convert Qualcomm SCM firmware binding to the yaml format.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> This patch comes with followup question -> since not all definitions
>> follow `"qcom,scm-*chipset*", "qcom,scm"`, should I change them or adjust this
>> binding to cover all cases?
>>
> 
> I don't remember why some platforms has the generic "fallback" and
> others doesn't. I don't have any objections to defining the binding as
> you've done.

Looking at the driver it seems that there some differences between
certain versions and generic qcom,scm. For example they require bus
clock which could mean they won't work without it on a "qcom,scm"
compatible. That could mean that original "qcom,scm" also required that
bus clock but it was for example always enabled. Or that clock was never
needed on "qcom,scm".

I think this should be converted without generic fallback, IOW, the
original bindings are not accurate and driver+DTS are better hints how
it should work.


Best regards,
Krzysztof

  reply	other threads:[~2022-04-10  8:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18 19:40 [PATCH] dt-bindings: firmware: convert Qualcomm SCM binding to the yaml David Heidelberg
2021-12-19 21:57 ` Rob Herring
2022-01-31 21:26 ` Bjorn Andersson
2022-04-10  8:50   ` Krzysztof Kozlowski [this message]
2022-04-10  8:58 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550e04f5-acd9-e50a-1aae-4e639951e35e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~okias/devicetree@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.