From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2GN-00037n-Ib for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya2GI-0003kw-Cj for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2GI-0003ke-8R for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:22 -0400 Message-ID: <551012D4.2070407@redhat.com> Date: Mon, 23 Mar 2015 14:19:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426953265-19940-1-git-send-email-pbonzini@redhat.com> <87twxct6yq.fsf@blackfin.pond.sub.org> <55100193.5000701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Edgar E. Iglesias" , Peter Crosthwaite , Markus Armbruster , QEMU Developers On 23/03/2015 13:09, Peter Maydell wrote: > > The only alternative for 2.3 is reverting the patch for sdhci-pci. I > > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI! > > What's wrong with that, incidentally? It's what I would have > expected for connecting an SD card to sdhci-pci, given > how the other SD controller devices work. (The only > difference with sdhci-pci is it happens to be a > pluggable device rather than hardwired into a board model.) Usually, "-drive if=" options (apart from if=none) are only handled at board creation time, and is not affected by -device. PCI devices use "-device sdhci-pci,drive=xyz" to tie themselves to a -drive option. Paolo